Add basic mingw_x86_64 build support (#1354)

* Add basic mingw_x86_64 build support
* Add mingw64 testing to CI
* Add mingw64 to py_build matrix and reduced MSYS2 dependencies

Signed-off-by: Mark Reid <[email protected]>

Author: markreidvfx

.github/workflows/python-package.yml

@@ -88,6 +88,15 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         python-version: ['2.7', '3.7', '3.8', '3.9', '3.10']
+        include:
+          - { os: ubuntu-latest, shell: bash }
+          - { os: macos-latest, shell: bash }
+          - { os: windows-latest, shell: pwsh }
+          - { os: windows-latest, shell: msys2, python-version: 'mingw64' }
+
+    defaults:
+      run:
+        shell: '${{ matrix.shell }} {0}'
 
     env:
       OTIO_CXX_COVERAGE_BUILD: ON
@@ -97,7 +106,20 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: 'recursive'
+    - name: Set up MSYS2
+      if: matrix.python-version == 'mingw64'
+      uses: msys2/setup-msys2@v2
+      with:
+        msystem: mingw64
+        install: >-
+          mingw-w64-x86_64-python
+          mingw-w64-x86_64-python-pip
+          mingw-w64-x86_64-gcc
+          mingw-w64-x86_64-cmake
+          make
+          git
     - name: Set up Python ${{ matrix.python-version }}
+      if: matrix.python-version != 'mingw64'
       uses: actions/setup-python@v3
       with:
         python-version: ${{ matrix.python-version }}

setup.py

@@ -75,6 +75,12 @@ def build(self):
         self.cmake_generate()
         self.cmake_install()
 
+    def is_windows(self):
+        return platform.system() == "Windows"
+
+    def is_mingw(self):
+        return self.plat_name.startswith('mingw')
+
     def generate_cmake_arguments(self):
         # Use the provided build dir so setuptools will be able to locate and
         # either install to the correct location or package.
@@ -99,9 +105,11 @@ def generate_cmake_arguments(self):
             # Python modules wil be installed by setuptools.
             '-DOTIO_INSTALL_PYTHON_MODULES:BOOL=OFF',
         ]
-
-        if platform.system() == "Windows":
-            cmake_args += ["-A", PLAT_TO_CMAKE[self.plat_name]]
+        if self.is_windows():
+            if self.is_mingw():
+                cmake_args += ['-G Unix Makefiles']
+            else:
+                cmake_args += ["-A", PLAT_TO_CMAKE[self.plat_name]]
 
         cxx_coverage = bool(os.environ.get("OTIO_CXX_COVERAGE_BUILD"))
         if cxx_coverage and not os.environ.get("OTIO_CXX_BUILD_TMP_DIR"):
@@ -159,7 +167,7 @@ def cmake_generate(self):
 
     def cmake_install(self):
         self.announce('running cmake build', level=2)
-        if platform.system() == "Windows":
+        if self.is_windows() and not self.is_mingw():
             multi_proc = '/m'
         else:
             multi_proc = '-j{}'.format(multiprocessing.cpu_count())

tests/test_plugin_detection.py

@@ -40,7 +40,7 @@ class TestSetuptoolsPlugin(unittest.TestCase):
     def setUp(self):
         # Get the location of the mock plugin module metadata
         mock_module_path = os.path.join(
-            baseline_reader.path_to_baseline_directory(),
+            os.path.normpath(baseline_reader.path_to_baseline_directory()),
             'plugin_module',
         )
         self.mock_module_manifest_path = os.path.join(

tests/test_url_conversions.py

@@ -49,7 +49,7 @@ def test_roundtrip_rel(self):
         result = otio.url_utils.filepath_from_url(MEDIA_EXAMPLE_PATH_URL_REL)
 
         # should have reconstructed it by this point
-        self.assertEqual(result, MEDIA_EXAMPLE_PATH_REL)
+        self.assertEqual(os.path.normpath(result), MEDIA_EXAMPLE_PATH_REL)
 
 
 if __name__ == "__main__":