otiotool --remove-effects no longer fails when it encounters a Transition.

Signed-off-by: Joshua Minor <[email protected]>
Co-authored-by: Yingjie Wang <[email protected]>

Author: jminor

src/py-opentimelineio/opentimelineio/console/otiotool.py

@@ -510,11 +510,13 @@ def _f(item):
 
 
 def filter_effects(timelines):
-    """Return a copy of the input timelines with all effects removed.
-    The overall duration of the timelines should not be affected, with
-    the possible exception of time warp effects, which are also removed."""
+    """Remove all effects from the input timelines. The inputs are modified
+    in place, and also returned."""
     for timeline in timelines:
-        for item in timeline.find_children():
+        # Items have an effects attribute, but other Composables do not.
+        # (e.g. Transitions) so we need to find only Items.
+        for item in timeline.find_children(descended_from_type=otio.core.Item):
+            # Clear the effects list contents
             item.effects[:] = []
     return timelines
 

tests/sample_data/effects.otio

@@ -362,6 +362,33 @@
                         },
                         "active_media_reference_key": "DEFAULT_MEDIA"
                     },
+                    {
+                        "OTIO_SCHEMA": "Transition.1",
+                        "metadata": {
+                            "Resolve_OTIO": {
+                                "Effects": {
+                                    "Effect Name": "Cross Fade 0 dB",
+                                    "Enabled": true,
+                                    "Name": "Cross Fade",
+                                    "Parameters": [],
+                                    "Type": 40
+                                },
+                                "Transition Type": "Cross Fade 0DB"
+                            }
+                        },
+                        "name": "Cross Fade 0 dB",
+                        "in_offset": {
+                            "OTIO_SCHEMA": "RationalTime.1",
+                            "rate": 24.0,
+                            "value": 30.0
+                        },
+                        "out_offset": {
+                            "OTIO_SCHEMA": "RationalTime.1",
+                            "rate": 24.0,
+                            "value": 30.0
+                        },
+                        "transition_type": "SMPTE_Dissolve"
+                    },
                     {
                         "OTIO_SCHEMA": "Clip.2",
                         "metadata": {