Copy metadata data in apv library (#109)

* Copy metadata data in apv library

- Fix memory leak on metadata payload
- Change metadata data to be copied by the apv library

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Adding error handle for mdp

- Add error handler when mdp data size is zero.
- Remove duplicated or unused code

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Add check condition for metadata set

- If memory allocation for mdp fails, the pld data should only be
  freed if size > 0.

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Change condition in meta_free_mdp_data()

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Clean-up metadata codes

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Fix vlc_metadata when payload_size is zero

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* Refactoring about metadata

- Remove metadata size
- Some code cleaning in the oapv_metadata.c

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>

* removed compilation error

Signed-off-by: Kwang Pyo Choi <kp5.choi@samsung.com>

* removed uuid parameter at oapvm_get()

Signed-off-by: Kwang Pyo Choi <kp5.choi@samsung.com>

* refactored code

Signed-off-by: Kwang Pyo Choi <kp5.choi@samsung.com>

---------

Signed-off-by: Yangwoo Kim <yearly.kim@samsung.com>
Signed-off-by: Kwang Pyo Choi <kp5.choi@samsung.com>
Co-authored-by: Yangwoo Kim <yearly.kim@samsung.com>
Co-authored-by: Kwang Pyo Choi <kp5.choi@samsung.com>

Author: 3 people

inc/oapv.h

@@ -631,9 +631,9 @@ typedef struct oapvm_payload oapvm_payload_t;
 struct oapvm_payload {
     int           group_id;  // group ID
     int           type;      // payload type
-    unsigned char uuid[16];  // UUID for user-defined metadata payload
+    int           size;      // byte size of metadata payload
     void         *data;      // address of metadata payload
-    int           data_size; // byte size of metadata payload
+    unsigned char uuid[16];  // UUID for user-defined metadata payload
 };
 
 /*****************************************************************************
@@ -643,12 +643,12 @@ typedef void       *oapvm_t; // instance identifier for OAPV metadata container
 
 OAPV_EXPORT oapvm_t oapvm_create(int *err);
 OAPV_EXPORT void oapvm_delete(oapvm_t mid);
-OAPV_EXPORT void oapvm_rem_all(oapvm_t mid);
-OAPV_EXPORT int oapvm_set(oapvm_t mid, int group_id, int type, void *data, int size, unsigned char *uuid);
+OAPV_EXPORT int oapvm_set(oapvm_t mid, int group_id, int type, void *data, int size);
 OAPV_EXPORT int oapvm_get(oapvm_t mid, int group_id, int type, void **data, int *size, unsigned char *uuid);
 OAPV_EXPORT int oapvm_rem(oapvm_t mid, int group_id, int type, unsigned char *uuid);
 OAPV_EXPORT int oapvm_set_all(oapvm_t mid, oapvm_payload_t *pld, int num_plds);
 OAPV_EXPORT int oapvm_get_all(oapvm_t mid, oapvm_payload_t *pld, int *num_plds);
+OAPV_EXPORT void oapvm_rem_all(oapvm_t mid);
 
 /*****************************************************************************
  * interface for encoder

src/oapv.c

@@ -1342,7 +1342,7 @@ int oapve_encode(oapve_t eid, oapv_frms_t *ifrms, oapvm_t mid, oapv_bitb_t *bitb
     if(md_list != NULL) {
         int num_md = md_list->num;
         for(i = 0; i < num_md; i++) {
-            int group_id = md_list->group_ids[i];
+            int group_id = md_list->md_arr[i].group_id;
             bs_pos_pbu_beg = oapv_bsw_sink(bs);            /* store pbu pos to calculate size */
             oapv_mcpy(&bs_pbu_beg, bs, sizeof(oapv_bs_t)); /* store pbu pos of ai to re-write */
             DUMP_SAVE(0);