Avoid unnecessary and expensive getLastWriteTime calls for memory mapped files on windows

jjtParadox · web-flow · commit 2d7ae513ef62 · 2025-02-27T09:25:54.000-06:00
Signed-off-by: jjtParadox &lt;jturner@4nsi.com&gt;
diff --git a/openvdb/openvdb/io/Archive.cc b/openvdb/openvdb/io/Archive.cc
@@ -554,6 +554,7 @@ MappedFile::filename() const
 SharedPtr<std::streambuf>
 MappedFile::createBuffer() const
 {
+#ifndef _WIN32
     if (!mImpl->mAutoDelete && mImpl->mLastWriteTime > 0) {
         // Warn if the file has been modified since it was opened
         // (but don't bother checking if it is a private, temporary file).
@@ -563,6 +564,7 @@ MappedFile::createBuffer() const
             mImpl->mLastWriteTime = 0; // suppress further warnings
         }
     }
+#endif
 
     return SharedPtr<std::streambuf>{
         new boost::iostreams::stream_buffer<boost::iostreams::array_source>{

Original file line number	Diff line number	Diff line change
`@@ -554,6 +554,7 @@ MappedFile::filename() const`
`554`	`554`	`SharedPtr<std::streambuf>`
`555`	`555`	`MappedFile::createBuffer() const`
`556`	`556`	`{`
	`557`	`+#ifndef _WIN32`
`557`	`558`	`if (!mImpl->mAutoDelete && mImpl->mLastWriteTime > 0) {`
`558`	`559`	`// Warn if the file has been modified since it was opened`
`559`	`560`	`// (but don't bother checking if it is a private, temporary file).`
`@@ -563,6 +564,7 @@ MappedFile::createBuffer() const`
`563`	`564`	`mImpl->mLastWriteTime = 0; // suppress further warnings`
`564`	`565`	`}`
`565`	`566`	`}`
	`567`	`+#endif`
`566`	`568`
`567`	`569`	`return SharedPtr<std::streambuf>{`
`568`	`570`	`new boost::iostreams::stream_buffer<boost::iostreams::array_source>{`