Skip to content

Commit 2e5f5d4

Browse files
committed
Add comments, add conditional based on matrix.config.image 2021 and 2022, remove sudo.
Signed-off-by: Andre Pradhana <[email protected]>
1 parent f77872a commit 2e5f5d4

File tree

5 files changed

+11
-2
lines changed

5 files changed

+11
-2
lines changed

.github/workflows/ax.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ jobs:
7575
fail-fast: false
7676
steps:
7777
- name: Enable Node 16
78+
if: contains(matrix.config.image, '2021') || contains(matrix.config.image, '2022')
7879
run: |
7980
echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
8081
- uses: actions/checkout@v3

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ jobs:
8787
fail-fast: false
8888
steps:
8989
- name: Enable Node 16
90+
# Solution taken from https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default
91+
if: contains(matrix.config.image, '2022')
9092
run: |
9193
echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
9294
- uses: actions/checkout@v3

.github/workflows/docs.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ jobs:
5555
# run: pip install epydoc
5656
- name: install_latex
5757
run: |
58+
# Fix error: Cannot prepare internal mirrorlist: No URLs in mirrorlist. CentOS 8 reached EOL means need to replace the official mirror to vault.centos.org
59+
# Comment out mirrorlist and replace #baseurl=...mirror.centos.org with baseurl=...vault.centos.org in files starting with CentOS- in /etc/yum.repos.d folder
5860
sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-*
5961
sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
6062
yum -y install texlive-latex-bin texlive-dvips texlive-collection-fontsrecommended texlive-collection-latexrecommended

.github/workflows/nanovdb.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,14 @@ jobs:
6666
fail-fast: false
6767
steps:
6868
- name: Enable Node 16
69+
if: contains(matrix.config.image, '2022')
6970
run: |
7071
echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
7172
- uses: actions/checkout@v3
7273
- name: install_cuda_11
7374
run: |
75+
# Fix error: Cannot prepare internal mirrorlist: No URLs in mirrorlist. CentOS 8 reached EOL means need to replace the official mirror to vault.centos.org
76+
# Comment out mirrorlist and replace #baseurl=...mirror.centos.org with baseurl=...vault.centos.org in files starting with CentOS- in /etc/yum.repos.d folder
7477
sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-*
7578
sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
7679
yum -y install yum-utils
@@ -167,12 +170,12 @@ jobs:
167170
run: ./ci/install_macos.sh
168171
- name: build
169172
run: >
170-
sudo ./ci/build.sh -v
173+
./ci/build.sh -v
171174
--build-type=${{ matrix.config.build }}
172175
--components=core,nano,nanotest,nanoexam,nanobench,nanotool
173176
--cargs=\'-DUSE_EXPLICIT_INSTANTIATION=OFF -DNANOVDB_USE_CUDA=OFF -DNANOVDB_USE_OPENVDB=ON\'
174177
- name: test
175-
run: cd build && sudo ctest -V -E ".*cuda.*"
178+
run: cd build && ctest -V -E ".*cuda.*"
176179

177180
nanovdb-lite:
178181
if: |

.github/workflows/weekly.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ jobs:
260260
fail-fast: false
261261
steps:
262262
- name: Enable Node 16
263+
if: contains(matrix.config.image, '2021') || contains(matrix.config.image, '2022')
263264
run: |
264265
echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
265266
- uses: actions/checkout@v3

0 commit comments

Comments
 (0)