Skip to content

Commit 56d06d1

Browse files
committed
Rename Committer to Maintainer
Ensure all TSC are Maintainers Add Jonathan Swartz as a Maintainer. Adjust voting procedure for new TSC members to require TSC approval, not maintainer approval. Signed-off-by: Jeff Lait <[email protected]>
1 parent 6719224 commit 56d06d1

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,36 +57,38 @@ code and has the right to release it under the
5757
[Mozilla Public License, version 2.0](LICENSE.md)
5858
license. See the [TAC documentation on contribution sign off](https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contribution-sign-off) for more information on this requirement.
5959

60-
## Committer
60+
## Maintainer
6161

62-
The committer role enables the participant to commit code directly to the repository, but also comes with the obligation to be a responsible leader in the community.
62+
The maintainer role is the equivalent of the "Committer" role in the charter.
6363

64-
### Process for becoming a committer
64+
This role enables the participant to commit code directly to the repository, but also comes with the obligation to be a responsible leader in the community.
65+
66+
### Process for becoming a maintainer
6567

6668
* Show your experience with the codebase through contributions and engagement on the community channels.
67-
* Request to become a committer.
68-
* Have the majority of committers approve you becoming a committer.
69+
* Request to become a maintainer.
70+
* Have the majority of maintainers approve you becoming a maintainer.
6971
* Your name and email is added to the MAINTAINERS.md file for the project.
7072

71-
### Committer responsibilities
73+
### Maintainer responsibilities
7274

7375
* Monitor email aliases.
7476
* Monitor Slack (delayed response is perfectly acceptable).
7577
* Triage GitHub issues and perform pull request reviews for other committers and the community.
7678
* Make sure that ongoing PRs are moving forward at the right pace or close them.
7779
* Remain an active contributor to the project in general and the code base in particular.
7880

79-
### When does a committer lose committer status?
81+
### When does a maintainer lose maintainer status?
8082

81-
If a committer is no longer interested or cannot perform the committer duties listed above, they
83+
If a maintainer is no longer interested or cannot perform the maintainer duties listed above, they
8284
should volunteer to be moved to emeritus status. In extreme cases this can also occur by a vote of
83-
the committers per the voting process below.
85+
the maintainers per the voting process below.
8486

8587
## Technical Steering Committee (TSC) member
8688

8789
The Technical Steering Committee (TSC) oversees the overall technical direction of OpenVDB, as defined in the [charter](charter.md).
8890

89-
TSC voting members consist of committers that have been nominated by the committers, with a supermajority of voting members required to have a committer elected to be a TSC voting member. TSC voting members term and succession is defined in the [charter](charter.md).
91+
TSC voting members consist of maintainers that have been nominated by the TSC, with a supermajority of voting members required to have a maintainer elected to be a TSC voting member. TSC voting members term and succession is defined in the [charter](charter.md).
9092

9193
All meetings of the TSC are open to participation by any member of the OpenVDB community. Meeting times are listed in the [ASWF technical community calendar](https://lists.aswf.io/g/tac/calendar).
9294

MAINTAINERS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,5 @@ The current OpenVDB maintainers are:
1414
| Ken Museth | [email protected]
1515
| Andre Pradhana | [email protected]
1616
| Richard Jones | [email protected]
17+
| Gergory Hurst | tbd
18+
| Jonathan Swartz | tbd

tsc/process/codereview.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
**Code Reviewing and Merging OpenVDB Pull Requests**
22

3-
The Technical Steering Committee have write-access to the OpenVDB repository and are responsible for triaging, reviewing and ultimately merging or rejecting GitHub pull requests. This document lists the policy and best practices to guide the TSC in this process.
3+
The Maintainers have write-access to the OpenVDB repository and are responsible for triaging, reviewing and ultimately merging or rejecting GitHub pull requests. This document lists the policy and best practices to guide the Maintainers in this process.
44

55
***Policy***
66

77
* No direct commits to the master (or any other protected) branch, every code change should be a pull request
88
* Any member of the community can provide feedback on any pull request (and is encouraged to do so)
99
* A CODEOWNERS file introduced to the root of the repo to configure ownership (global, per-directory and/or per-file) - this will automatically request pull request reviews from the relevant maintainers (https://help.github.com/articles/about-codeowners/)
10-
* Minimum of one non-author TSC member approval on every pull request before merging
10+
* Minimum of one non-author Maintainer member approval on every pull request before merging
1111
* Non fast-forward merges must be used (ie the merge must not be rebased onto master)
1212
* Travis CI and DCO status checks must strictly pass before merging, ASWF Jenkins CI should loosely pass (https://help.github.com/articles/types-of-required-status-checks)
1313

1414
***Best Practices***
1515

1616
* Prefer all requested reviewers to approve before merging
17-
* Merging a pull request should be the responsibility of the author if they are a TSC member
18-
* Any TSC member can merge a pull request authored by a non-TSC member, but with a preferred minimum of two approvals from TSC members (including themself)
17+
* Merging a pull request should be the responsibility of the author if they are a Maintainer member
18+
* Any Maintainer member can merge a pull request authored by a non-Maintainer member, but with a preferred minimum of two approvals from Maintainer members (including themself)
1919
* Re-writing the branch history by rebasing a pull request branch just before a merge is discouraged, unless it significantly improves the overall history (such as any broken commits on the review branch that might make reverting or bisecting more difficult)
2020
* Prefer pull requests to be open for a minimum of 72 hours before merging in order to gather any feedback
21-
* Aim for all pull requests to be responded to by one of the TSC members within a minimum of two weeks with either explanation of non-acceptance, request for changes or merge
21+
* Aim for all pull requests to be responded to by one of the Maintainer members within a minimum of two weeks with either explanation of non-acceptance, request for changes or merge
2222
* TSC meetings should regularly review and discuss any outstanding pull requests
2323
* Pull requests should link to the associated Jira ticket (if applicable) in the description or title, this provides a route back to the Jira ticket through the Git history (git blame -> PR merge -> Jira ticket)
2424
* All pull request comments should aim to be answered and resolved before committing

0 commit comments

Comments
 (0)