|
| 1 | +Minutes from 129-th OpenVDB TSC meeting, April 12th, 2022, (EDT) |
| 2 | + |
| 3 | +Attendees: *Jeff* L., *Nick* A, *Dan* B., *Rich* J., *Andre* P. |
| 4 | + |
| 5 | +Additional Attendees: Sebastian Gaida, Serjio Rojas, Greg Hurst |
| 6 | +(United Therapeutics), Kyle Wardlow (United Therapeutics). |
| 7 | + |
| 8 | +Regrets: *Ken* M. |
| 9 | + |
| 10 | +Agenda: |
| 11 | + |
| 12 | +1) Confirm quorum |
| 13 | +2) Secretary |
| 14 | +3) Forum |
| 15 | +4) Typelists (PR #1336) |
| 16 | +5) Binary re-structure (PR #1319) |
| 17 | +6) Wolfram/Mathematica Integration (PR #1351) |
| 18 | +7) Next meeting |
| 19 | + |
| 20 | + |
| 21 | +-------------------- |
| 22 | + |
| 23 | +1) Confirm quorum |
| 24 | + |
| 25 | +Quorum is present. |
| 26 | + |
| 27 | +2) Secretary |
| 28 | + |
| 29 | +Secretary is Dan Bailey. |
| 30 | + |
| 31 | +3) Forum |
| 32 | + |
| 33 | +a) #1350 |
| 34 | + |
| 35 | +Questioning the choice of std::deque on Windows. No benchmarking data shared, in |
| 36 | +many cases using a deque was a conscious choice as the data is not moved when |
| 37 | +extended so works better when multi-threading. Jeff to reply. Nick removed bug |
| 38 | +label, default should be to close issues such as this where there's no issue |
| 39 | +that needs to be addressed. |
| 40 | + |
| 41 | +b) Two dimensional grid Qs |
| 42 | + |
| 43 | +This has been on the roadmap for years. A single slice of a 3D grid can work in |
| 44 | +many cases, although care must be taken with level sets. Main issue with this |
| 45 | +approach is a significantly larger memory footprint. |
| 46 | + |
| 47 | +4) Typelists (PR #1336) |
| 48 | + |
| 49 | +Nick has extended slightly to improve unique implementation. Now uniqueness is |
| 50 | +enforced on append instead of at the end of the template expansion which is |
| 51 | +more efficient. Uses std::conditional which sometimes instantiates false branch |
| 52 | +and sometimes doesn't. Const Expr If with C++17 should handle this better. |
| 53 | + |
| 54 | +Where to add custom grid support? Makes most sense to put it in |
| 55 | +openvdb::initialize(), however this may mean that methods that use the dynamic |
| 56 | +dispatch will not be able to support this custom grid. |
| 57 | + |
| 58 | +Most important is to align the categories - with this change, they will exist in |
| 59 | +three places as they are also in CMake for explicit instantiation and in |
| 60 | +Houdini plugins. One inconsistency is scalar vs numeric grid types for |
| 61 | +example. |
| 62 | + |
| 63 | +5) Binary re-structure (PR #1319) |
| 64 | + |
| 65 | +Might have to leave OPENVDB_BUILD_BINARIES for now. Not trivial to remove it as |
| 66 | +not clear how custom allocators or building binaries against an external |
| 67 | +libopenvdb will work. Dan to comment on PR for further discussion. |
| 68 | + |
| 69 | +6) Wolfram/Mathematica Integration (PR #1351) |
| 70 | + |
| 71 | +Greg to do a half hour presentation next time on some of the integration |
| 72 | +questions. |
| 73 | + |
| 74 | +Work still to do be done on improving the docs. Need to be some minor changes to |
| 75 | +the whitespace CI rules to exclude certain subdirs, particularly around autogen |
| 76 | +code. |
| 77 | + |
| 78 | +This PR adds a lot of code. Question about whether or not it might be feasible |
| 79 | +to exclude the 400k+ lines of autogen code and to do this on the fly? |
| 80 | + |
| 81 | +Main issue to investigate is the CI and licensing. Wolfram Engine is available |
| 82 | +for this kind of purpose, but need to follow up with TAC / John Mertic to find |
| 83 | +out more. Three options to pursue: |
| 84 | + |
| 85 | +* Full CI integration to build and evaluate unit tests using Wolfram/Mathematica |
| 86 | + licenses. |
| 87 | +* Houdini-style build-only integration that ensures compilation is successful |
| 88 | + but does no evaluation. |
| 89 | +* Minimal build only components that do not include Wolfram headers/libs. |
| 90 | + |
| 91 | +After discussions with ASWF, should be clearer which one is preferred. |
| 92 | + |
| 93 | +Question about openvdb_wolfram instead of openvdb_mathematica? Although |
| 94 | +Mathematica is the main product, there is also Wolfram Engine. Greg's call on |
| 95 | +which makes most sense. |
| 96 | + |
| 97 | +7) Next meeting |
| 98 | + |
| 99 | +Next meeting is on April 19th, 2022. 1pm-2pm EDT (GMT-4). |
0 commit comments