Skip to content

Commit beb3a56

Browse files
committed
Apply feedback - use Real and Numeric insetad of Float and Scalar
Signed-off-by: Nick Avramoussis <[email protected]>
1 parent 0407c65 commit beb3a56

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

openvdb/openvdb/openvdb.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,19 +88,19 @@ using VectorGrid = Vec3fGrid;
8888
/// @name Lists of native Grid Types
8989
/// @{
9090
/// The floating point Grid types which OpenVDB will register by default.
91-
using FloatGridTypes = TypeList<FloatGrid, DoubleGrid>;
91+
using RealGridTypes = TypeList<FloatGrid, DoubleGrid>;
9292
/// The integer Grid types which OpenVDB will register by default.
9393
using IntegerGridTypes = TypeList<Int32Grid, Int64Grid>;
9494
/// The scalar Grid types which OpenVDB will register by default. This is a
9595
/// combination of native floating point and integer grid types. Note that
9696
/// this list does not include Bool or Mask Grids.
97-
using ScalarGridTypes = FloatGridTypes::Append<IntegerGridTypes>;
97+
using NumericGridTypes = RealGridTypes::Append<IntegerGridTypes>;
9898
/// The Vec3 Grid types which OpenVDB will register by default.
9999
using Vec3GridTypes = TypeList<Vec3IGrid, Vec3SGrid, Vec3DGrid>;
100100

101101
/// The Grid types which OpenVDB will register by default.
102102
using GridTypes =
103-
ScalarGridTypes::
103+
NumericGridTypes::
104104
Append<Vec3GridTypes>::
105105
Append<tools::PointIndexGrid>::
106106
// #define unfortunately required for one of the tests that removes this alias
@@ -114,7 +114,7 @@ using GridTypes =
114114
/// @name Lists of native TypedAttributeArray Types (for PointDataGrids)
115115
/// @{
116116
/// The floating point attribute array types which OpenVDB will register by default.
117-
using FloatAttributeTypes = TypeList<
117+
using RealAttributeTypes = TypeList<
118118
points::TypedAttributeArray<float>,
119119
points::TypedAttributeArray<double>,
120120
points::TypedAttributeArray<float, points::TruncateCodec>,
@@ -131,8 +131,8 @@ using IntegerAttributeTypes = TypeList<
131131
/// The scalar attribute array types which OpenVDB will register by default.
132132
/// This is a combination of native floating point and integer array types.
133133
/// Note that this list does not include bool arrays.
134-
using ScalarAttributeTypes =
135-
FloatAttributeTypes::Append<IntegerAttributeTypes>;
134+
using NumericAttributeTypes =
135+
RealAttributeTypes::Append<IntegerAttributeTypes>;
136136
/// The Vec3 attribute array types which OpenVDB will register by default.
137137
using Vec3AttributeTypes = TypeList<
138138
points::TypedAttributeArray<math::Vec3<int32_t>>,
@@ -163,7 +163,7 @@ using QuatAttributeTypes = TypeList<
163163

164164
/// The attribute array types which OpenVDB will register by default.
165165
using AttributeTypes =
166-
ScalarAttributeTypes::
166+
NumericAttributeTypes::
167167
Append<Vec3AttributeTypes>::
168168
Append<Mat3AttributeTypes>::
169169
Append<Mat4AttributeTypes>::

openvdb/openvdb/unittest/TestTypes.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -793,31 +793,31 @@ TEST_F(TestTypes, testOpenVDBTypeLists)
793793
STATIC_ASSERT((std::is_same<LIST_T::Unique<>, LIST_T>::value));
794794

795795
CHECK_TYPE_LIST_IS_VALID(GridTypes)
796-
CHECK_TYPE_LIST_IS_VALID(FloatGridTypes)
796+
CHECK_TYPE_LIST_IS_VALID(RealGridTypes)
797797
CHECK_TYPE_LIST_IS_VALID(IntegerGridTypes)
798-
CHECK_TYPE_LIST_IS_VALID(ScalarGridTypes)
798+
CHECK_TYPE_LIST_IS_VALID(NumericGridTypes)
799799
CHECK_TYPE_LIST_IS_VALID(Vec3GridTypes)
800800

801801
GridTypes::foreach<IsRegistered>();
802802

803-
FloatGridTypes::foreach<GridListContains>();
803+
RealGridTypes::foreach<GridListContains>();
804804
IntegerGridTypes::foreach<GridListContains>();
805-
ScalarGridTypes::foreach<GridListContains>();
805+
NumericGridTypes::foreach<GridListContains>();
806806
Vec3GridTypes::foreach<GridListContains>();
807807

808808
CHECK_TYPE_LIST_IS_VALID(AttributeTypes)
809809
CHECK_TYPE_LIST_IS_VALID(IntegerAttributeTypes)
810-
CHECK_TYPE_LIST_IS_VALID(ScalarAttributeTypes)
810+
CHECK_TYPE_LIST_IS_VALID(NumericAttributeTypes)
811811
CHECK_TYPE_LIST_IS_VALID(Vec3AttributeTypes)
812812
CHECK_TYPE_LIST_IS_VALID(Mat3AttributeTypes)
813813
CHECK_TYPE_LIST_IS_VALID(Mat4AttributeTypes)
814814
CHECK_TYPE_LIST_IS_VALID(QuatAttributeTypes)
815815

816816
AttributeTypes::foreach<IsRegistered>();
817817

818-
FloatAttributeTypes::foreach<AttrListContains>();
818+
RealAttributeTypes::foreach<AttrListContains>();
819819
IntegerAttributeTypes::foreach<AttrListContains>();
820-
ScalarAttributeTypes::foreach<AttrListContains>();
820+
NumericAttributeTypes::foreach<AttrListContains>();
821821
Vec3AttributeTypes::foreach<AttrListContains>();
822822
Mat3AttributeTypes::foreach<AttrListContains>();
823823
Mat4AttributeTypes::foreach<AttrListContains>();

0 commit comments

Comments
 (0)