Merge pull request #1114 from Idclip/mingw

Fixes for building for Windows with MinGW

Author: Idclip

openvdb/openvdb/CMakeLists.txt

@@ -508,7 +508,7 @@ if(OPENVDB_CORE_STATIC)
   set_target_properties(openvdb_static
     PROPERTIES OUTPUT_NAME ${OPENVDB_STATIC_LIBRARY_NAME})
 
-  if(WIN32)
+  if(MSVC)
     if(NOT CMAKE_MSVC_RUNTIME_LIBRARY)
       # NOTE: MSVC_RUNTIME_LIBRARY does not propagate to targets, so
       # also add it explicitly as a compile option
@@ -559,7 +559,7 @@ if(OPENVDB_CORE_SHARED)
     )
   endif()
 
-  if(WIN32)
+  if(MSVC)
     if(NOT CMAKE_MSVC_RUNTIME_LIBRARY)
       # NOTE: MSVC_RUNTIME_LIBRARY does not propagate to targets, so
       # also add it explicitly as a compile option

openvdb/openvdb/io/TempFile.cc

@@ -70,7 +70,11 @@ struct TempFile::TempFileImpl
     {
         if (const char* dir = std::getenv("OPENVDB_TEMP_DIR")) {
             if (0 != ::access(dir, F_OK)) {
+#ifdef _WIN32
+                ::mkdir(dir);
+#else
                 ::mkdir(dir, S_IRUSR | S_IWUSR | S_IXUSR);
+#endif
                 if (0 != ::access(dir, F_OK)) {
                     OPENVDB_THROW(IoError,
                         "failed to create OPENVDB_TEMP_DIR (" + std::string(dir) + ")");

pendingchanges/mingw.txt

@@ -0,0 +1,3 @@
+Build:
+  - Build fixes for MinGW on Windows
+  [Contributed by Brecht Sanders]