Fixed unnecessary null pointer check.

Signed-off-by: Lucas Baraya <[email protected]>

Author: Luc35b

openvdb/openvdb/math/ConjGradient.h

@@ -588,7 +588,7 @@ inline void
 Vector<T>::resize(SizeType n)
 {
     if (n != mSize) {
-        if (mData) delete[] mData;
+        delete[] mData;
         mData = new T[n];
         mSize = n;
     }

openvdb/openvdb/tools/DenseSparseTools.h

@@ -371,7 +371,7 @@ class SparseExtractor
 
         // Clean up an unused leaf.
 
-        if (leaf != nullptr) delete leaf;
+        delete leaf;
     }
 
     void join(SparseExtractor& rhs) {
@@ -530,7 +530,7 @@ class SparseMaskedExtractor
 
         // Clean up an unused leaf.
 
-        if (leaf != nullptr) delete leaf;
+        delete leaf;
     }
 
     void join(SparseMaskedExtractor& rhs) {

openvdb/openvdb/tools/LevelSetUtil.h

@@ -221,7 +221,7 @@ struct MaskInteriorVoxels {
             }
         }
 
-        if (maskNodePt) delete maskNodePt;
+        delete maskNodePt;
     }
 
     LeafNodeType        const * const * const mNodes;
@@ -346,7 +346,7 @@ struct LabelBoundaryVoxels {
             }
         }
 
-        if (maskNodePt) delete maskNodePt;
+        delete maskNodePt;
     }
 
     LeafNodeType        const * const * const mNodes;
@@ -1254,7 +1254,7 @@ struct MaskIsovalueCrossingVoxels
             }
         }
 
-        if (maskNodePt) delete maskNodePt;
+        delete maskNodePt;
     }
 
     void join(MaskIsovalueCrossingVoxels& rhs) {

openvdb/openvdb/tree/LeafBuffer.h

@@ -330,7 +330,7 @@ template<typename T, Index Log2Dim>
 inline bool
 LeafBuffer<T, Log2Dim>::deallocate()
 {
-    if (mData != nullptr && !this->isOutOfCore()) {
+    if (!this->isOutOfCore()) {
         delete[] mData;
         mData = nullptr;
         return true;

openvdb_cmd/vdb_view/Viewer.cc

@@ -189,11 +189,9 @@ init(const std::string& progName, bool background)
     if (background) {
         if (sThreadMgr == nullptr) {
             std::lock_guard<std::mutex> lock(sLock);
-            if (sThreadMgr == nullptr) {
-                OPENVDB_START_THREADSAFE_STATIC_WRITE
-                sThreadMgr = new ThreadManager;
-                OPENVDB_FINISH_THREADSAFE_STATIC_WRITE
-            }
+            OPENVDB_START_THREADSAFE_STATIC_WRITE
+            sThreadMgr = new ThreadManager;
+            OPENVDB_FINISH_THREADSAFE_STATIC_WRITE
         }
     } else {
         if (sThreadMgr != nullptr) {

openvdb_houdini/openvdb_houdini/SOP_OpenVDB_Rasterize_Points.cc

@@ -1401,7 +1401,7 @@ struct WeightedAverageOp
     {
     }
 
-    ~WeightedAverageOp() { if (mNode) delete mNode; }
+    ~WeightedAverageOp() { delete mNode; }
 
     const char* getName() const { return mHandle.getAttribute()->getName(); }
 
@@ -1693,7 +1693,7 @@ struct Attribute
         clearNodes();
 
         for (size_t n = 0, N = mOutputNodes.size(); n < N; ++n) {
-            if (mOutputNodes[n] != nullptr) delete mOutputNodes[n];
+            delete mOutputNodes[n];
         }
     }
 
@@ -1702,7 +1702,7 @@ struct Attribute
     void clearNodes()
     {
         for (size_t n = 0; n < mNodeCount; ++n) {
-            if (mNodes[n] != nullptr) delete mNodes[n];
+            delete mNodes[n];
         }
     }