Skip to content

Commit fb4db37

Browse files
committed
Fix merge problems
1 parent 32967af commit fb4db37

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

src/plugin/colour_pipeline/ocio/src/ocio_engine.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ void OCIOEngine::extend_pixel_info(
327327
OCIO::ConstConfigRcPtr
328328
OCIOEngine::get_ocio_config(const utility::JsonStore &src_colour_mgmt_metadata) const {
329329

330-
const std::string config_name =
330+
std::string config_name =
331331
utility::forward_remap_file_path(
332332
src_colour_mgmt_metadata.get_or("ocio_config", default_config_));
333333
const std::string displays =
@@ -393,7 +393,7 @@ OCIOEngine::get_ocio_config(const utility::JsonStore &src_colour_mgmt_metadata)
393393
}
394394

395395
config = econfig;
396-
ocio_config_cache_[concat] = config;
396+
ocio_config_cache_[config_cache_key] = config;
397397

398398
return config;
399399
}

src/plugin/viewport_overlay/annotations/src/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ target_link_libraries(${PROJECT_NAME}
2929
xstudio::plugin_manager
3030
xstudio::ui::opengl::viewport
3131
Imath::Imath
32+
Qt6::Core
3233
)
3334

3435
set_target_properties(${PROJECT_NAME} PROPERTIES LINK_DEPENDS_NO_SHARED true)

src/plugin/viewport_overlay/annotations/src/annotations_ui_plugin.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ void AnnotationsUI::start_item(const ui::PointerEvent &e) {
460460
payload["point"]["y"] = float(e.y())/float(e.height());
461461
payload["viewport"] = e.context();
462462

463-
const auto colour = std::vector<float>({pen_colour_->value().r, pen_colour_->value().g, pen_colour_->value().b, (current_tool() == Brush ? brush_opacity_->value() : pen_opacity_->value()) / 100.0});
463+
const auto colour = std::vector<float>({pen_colour_->value().r, pen_colour_->value().g, pen_colour_->value().b, (current_tool() == Brush ? brush_opacity_->value() : pen_opacity_->value()) / 100.0f});
464464

465465
switch (current_tool()) {
466466
case Draw:

ui/qml/xstudio/views/viewport/XsViewport.qml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ Viewport {
132132
// in the ViewportHUD qml code so we create a dummy property here
133133
property var hud_plugins_display_data
134134

135+
property var subPlayheadIdx: viewportPlayhead.keySubplayheadIndex != undefined ? viewportPlayhead.keySubplayheadIndex : 0
136+
135137
// this one lays out the HUD graphics coming from HUD plugins and
136138
// also general overlay graphics like Mask
137139
Repeater {
@@ -141,7 +143,7 @@ Viewport {
141143
// we are in grid mode, it's the index in the model here. If we're not in
142144
// a grid layout 'num_images_on_screen' is 1 and we need to use the
143145
// active sub playhead index.
144-
imageIndex: num_images_on_screen == 1 ? viewportPlayhead.keySubplayheadIndex : index
146+
imageIndex: num_images_on_screen == 1 ? subPlayheadIdx : index
145147
}
146148
}
147149

0 commit comments

Comments
 (0)