asdf3.2+lisp-unit compilation failure

[mirkov]

In file interop.lisp the function lisp-unit1-collection-context depends on the asdf/operate:systems-being-operated special variable.

This variable is not defined in ASDF 3.2 or 3.3, (it is defined in ASDF 3.1). I do not know what has replaced it.

Mirko

[bobbysmith007]

Thanks for pointing that out. I also started getting warnings about the way my subsystems are defined in most recent asdf / sbcl, so I guess its time to make a big maintenance sweep.

[mirkov]

Did a bit of searching in ASDF's git repo.

Variable *systems-being-operated* was replaced with *in-operate* in ASDF commit 7c3f979c

I am not sure if a simple replacement would work. *in-operate* looks to be a boolean. But, ASDF's operation is dark magic for me.

[mirkov]

I few more comments regarding this bug.

The problem shows up when the feature LISP-UNIT is set. Otherwise, the code compiles cleanly.

I also think the offending lisp-unit2's code is incorrectly written

The lisp-unit2 code in question is in file interop.lisp (link@github, line 62) which references asdf/operate:systems-being-operated (which is NIL or a hash)

This variable is passed to the method convert-test-results where it is used as a name. The bug is that a hash table is used as a name.

[bobbysmith007]

Dang.... Thanks for your work. I'll try to get around to it soon. I'm not employed with lisp anymore, but I do wish to continue to support Cheers, Russ

…

On Tue, Jun 4, 2019, 11:04 PM Mirko ***@***.***> wrote: I few more comments regarding this bug. The problem shows up when the feature LISP-UNIT is set. Otherwise, the code compiles cleanly. I also think the offending lisp-unit2's code is incorrectly written The lisp-unit2 code in question is in file interop.lisp ***@***.***, line 62) which references asdf/operate:*systems-being-operated* (which is NIL or a hash) This variable is passed to the method convert-test-results where it is used as a name. The bug is that a hash table is used as a name. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AAATNT5OKFPDJBYWIWZXZ2DPY4ULRA5CNFSM4EKI543KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6O7YI#issuecomment-498921441>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAATNT54GAKFMGUBDHIUCMLPY4ULRANCNFSM4EKI543A> .