fix: payment notificaiton

Author: Ajit Kumar

package.json

@@ -64,9 +64,9 @@
     "build": "yarn config-build p && webpack --mode production",
     "dev": "node ./dev/start-dev",
     "update-schema": "node ./updateSchema",
-    "download": "node ./server/reportsCli",
     "start": "node ./server/main",
-    "sitemap": "node dev/generateSitemap.js"
+    "sitemap": "node dev/generateSitemap.js",
+    "reports": "node ./server/reportsCli"
   },
   "browserslist": [
     "> 0.25%, not dead"

server/lib/updateEarnings.js

@@ -63,13 +63,8 @@ async function updateEarnings(year = currentYear, month = currentMonth) {
 
     for (const user of users) {
       const { payment_method_id, email, name } = user;
-      let { threshold } = user;
-
-      if (!payment_method_id) {
-        sendEmail(email, name, 'Payment method not found', 'Please add payment method to receive payment.');
-      }
-
       const earnings = await calcEarnings.total(year, month, user, report);
+      let { threshold } = user;
 
       const [row] = await UserEarnings.get([
         [UserEarnings.USER_ID, user.id],
@@ -104,6 +99,10 @@ async function updateEarnings(year = currentYear, month = currentMonth) {
       // create integer random unique payment id
       const paymentId = Math.floor(Math.random() * 1000000000);
 
+      if (!payment_method_id) {
+        sendEmail(email, name, 'Payment method not found', 'Please add payment method to receive payment.');
+      }
+
       await Payment.insert(
         [Payment.ID, paymentId],
         [Payment.USER_ID, user.id],