Skip to content

Commit 0f24e36

Browse files
committed
Temporarily skip some install and update integration tests on ARM.
1 parent 9e88135 commit 0f24e36

File tree

4 files changed

+20
-0
lines changed

4 files changed

+20
-0
lines changed

cmd/state-installer/test/integration/installer_int_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ func (suite *InstallerIntegrationTestSuite) TestInstallIncompatible() {
147147
}
148148

149149
func (suite *InstallerIntegrationTestSuite) TestInstallNoErrorTips() {
150+
if runtime.GOARCH == "arm64" {
151+
suite.T().Skip("ARM platform projects are not supported yet")
152+
}
150153
suite.OnlyRunForTags(tagsuite.Installer, tagsuite.Critical)
151154
ts := e2e.New(suite.T(), false)
152155
defer ts.Close()

test/integration/install_scripts_int_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"fmt"
66
"path/filepath"
77
"runtime"
8+
"strings"
89
"testing"
910

1011
"github.com/ActiveState/cli/internal/config"
@@ -48,6 +49,9 @@ func (suite *InstallScriptsIntegrationTestSuite) TestInstall() {
4849
}
4950

5051
for _, tt := range tests {
52+
if runtime.GOARCH == "arm64" && strings.Contains(tt.Name, "activate") {
53+
continue // ARM platform projects are not supported yet
54+
}
5155
suite.Run(fmt.Sprintf("%s (%s@%s)", tt.Name, tt.Version, tt.Channel), func() {
5256
ts := e2e.New(suite.T(), false)
5357
defer ts.Close()

test/integration/update_int_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -357,6 +357,9 @@ func (suite *UpdateIntegrationTestSuite) installLatestReleaseVersion(ts *e2e.Ses
357357
}
358358

359359
func (suite *UpdateIntegrationTestSuite) TestAutoUpdateToCurrent() {
360+
if runtime.GOARCH == "arm64" {
361+
suite.T().Skip("There is no official ARM release for install.sh yet")
362+
}
360363
suite.OnlyRunForTags(tagsuite.Update, tagsuite.Critical)
361364

362365
ts := e2e.New(suite.T(), false)
@@ -376,6 +379,9 @@ func (suite *UpdateIntegrationTestSuite) TestUpdateToCurrent() {
376379
// Feel free to drop this once the release channel is no longer on 0.29
377380
suite.T().Skip("Updating from release 0.29 to 0.30 is not covered due to how 0.29 did updates (async)")
378381
}
382+
if runtime.GOARCH == "arm64" {
383+
suite.T().Skip("There is no official ARM release for install.sh yet")
384+
}
379385
suite.OnlyRunForTags(tagsuite.Update, tagsuite.Critical)
380386

381387
ts := e2e.New(suite.T(), false)

test/integration/update_lock_int_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"os"
66
"path/filepath"
77
"regexp"
8+
"runtime"
89

910
"github.com/ActiveState/cli/internal/config"
1011
"github.com/ActiveState/cli/internal/constants"
@@ -16,6 +17,9 @@ import (
1617
)
1718

1819
func (suite *UpdateIntegrationTestSuite) TestLocked() {
20+
if runtime.GOARCH == "arm64" {
21+
suite.T().Skip("There is no official ARM release for install.sh yet")
22+
}
1923
suite.OnlyRunForTags(tagsuite.Update)
2024
suite.T().Skip("Requires https://www.pivotaltracker.com/story/show/177827538 and needs to be adapted.")
2125
pjfile := projectfile.Project{
@@ -44,6 +48,9 @@ func (suite *UpdateIntegrationTestSuite) TestLocked() {
4448
}
4549

4650
func (suite *UpdateIntegrationTestSuite) TestLockedChannel() {
51+
if runtime.GOARCH == "arm64" {
52+
suite.T().Skip("There is no official ARM release for install.sh yet")
53+
}
4754
suite.OnlyRunForTags(tagsuite.Update)
4855
targetBranch := "release"
4956
if constants.ChannelName == "release" {

0 commit comments

Comments
 (0)