Skip to content

Commit 6c7214a

Browse files
committed
Run secrets tests with larger bit size
1 parent 1a798de commit 6c7214a

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

internal/keypairs/rsa.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
)
1414

1515
// MinimumRSABitLength is the minimum allowed bit-length when generating RSA keys.
16-
const MinimumRSABitLength int = 12
16+
const MinimumRSABitLength int = 1024
1717

1818
type ErrKeypairPassphrase struct{ *locale.LocalizedError }
1919

internal/keypairs/rsa_keypair_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,5 @@ func (suite *RSAKeypairTestSuite) TestParseEncryptedRSA_IncorrectPassphrase() {
188188
}
189189

190190
func Test_RSAKeypair_TestSuite(t *testing.T) {
191-
t.Skip("This is still captured by integration tests, but for now we're skipping the unit test as it" +
192-
" prevents CI from running and we need time to devise a proper solution.")
193191
suite.Run(t, new(RSAKeypairTestSuite))
194192
}

internal/secrets/share_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ func (suite *SecretsSharingTestSuite) TestFailure_FirstShareHasBadlyEncryptedVal
5353
}
5454

5555
func (suite *SecretsSharingTestSuite) TestFailure_FailedToEncryptForTargetUser() {
56-
suite.T().Skip("This is still captured by integration tests, but for now we're skipping the unit test as it" +
57-
" prevents CI from running and we need time to devise a proper solution.")
5856
shortKeypair, err := keypairs.GenerateRSA(keypairs.MinimumRSABitLength)
5957
suite.Require().NoError(err)
6058

0 commit comments

Comments
 (0)