state commit should error if there is nothing new to commit.

Author: mitchell-as

internal/runners/commit/commit.go

@@ -35,6 +35,8 @@ func New(p primeable) *Commit {
 	return &Commit{p}
 }
 
+var errNoNewChanges = errs.New("no new changes")
+
 func rationalizeError(err *error) {
 	var buildPlannerErr *bpResp.BuildPlannerError
 
@@ -57,6 +59,9 @@ func rationalizeError(err *error) {
 	case errors.As(*err, &invalidDepValueType{}):
 		*err = errs.WrapUserFacing(*err, locale.T("err_commit_invalid_dep_value_type"), errs.SetInput())
 
+	case errors.Is(*err, errNoNewChanges):
+		*err = errs.WrapUserFacing(*err, locale.Tl("commit_notice_no_change", "Your buildscript contains no new changes. No commit necessary."), errs.SetInput())
+
 	}
 }
 
@@ -101,8 +106,7 @@ func (c *Commit) Run() (rerr error) {
 
 	// Check if there is anything to commit
 	if equals {
-		out.Notice(locale.Tl("commit_notice_no_change", "Your buildscript contains no new changes. No commit necessary."))
-		return nil
+		return errNoNewChanges
 	}
 
 	pg := output.StartSpinner(out, locale.T("progress_commit"), constants.TerminalAnimationInterval)

test/integration/buildscript_int_test.go

@@ -75,7 +75,7 @@ Project: %s
 Time: "2024-10-30T21:31:33.000Z"
 %s
 wheel = make_wheel(
-	at_time = at_time,
+	at_time = TIME,
 	src = tag(
 		plan = ingredient(
 			build_deps = [
@@ -111,7 +111,7 @@ main = wheel
 	// already exists with the given hash.
 	cp = ts.Spawn("commit")
 	cp.Expect("no new changes")
-	cp.ExpectExit()
+	cp.ExpectNotExitCode(0)
 
 	// Commit should've given us the hash
 	suite.Contains(string(fileutils.ReadFileUnsafe(filepath.Join(ts.Dirs.Work, constants.BuildScriptFileName))), "hash_readonly")

test/integration/commit_int_test.go

@@ -35,7 +35,7 @@ func (suite *CommitIntegrationTestSuite) TestCommitManualBuildScriptMod() {
 
 	cp := ts.Spawn("commit")
 	cp.Expect("no new changes")
-	cp.ExpectExitCode(0)
+	cp.ExpectNotExitCode(0)
 
 	_, err = buildscript_runbit.ScriptFromProject(proj)
 	suite.Require().NoError(err) // verify validity