Skip to content

Commit eeac0f2

Browse files
committed
Remove incorrect mutex.
Save is only called once, and since Save calls Track, which also uses this mutex, we get a deadlock.
1 parent ceafc3b commit eeac0f2

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

pkg/runtime/depot.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -441,9 +441,6 @@ func (d *depot) getSharedFilesToRedeploy(id strfmt.UUID, deploy deployment, path
441441
// Save will write config changes to disk (ie. links between depot artifacts and runtimes that use it).
442442
// It will also delete any stale artifacts which are not used by any runtime.
443443
func (d *depot) Save() error {
444-
d.mapMutex.Lock()
445-
defer d.mapMutex.Unlock()
446-
447444
// Mark artifacts that are no longer used and remove the old ones.
448445
for id := range d.artifacts {
449446
if deployments, ok := d.config.Deployments[id]; !ok || len(deployments) == 0 {

0 commit comments

Comments
 (0)