Merge pull request #3796 from ActiveState/mitchell/cp-1284-2

mitchell-as · web-flow · commit f2a4d4b5c6b6 · 2025-12-24T14:15:16.000-05:00
Do not log WaitForEvents warning.
diff --git a/cmd/state-svc/main.go b/cmd/state-svc/main.go
@@ -55,7 +55,10 @@ func main() {
 		}
 
 		if err := events.WaitForEvents(5*time.Second, rollbar.Wait, authentication.LegacyClose, logging.Close); err != nil {
-			fmt.Fprintf(os.Stderr, "Warning: failed to wait for events")
+			// Note: logger is closed, so cannot log here. Also, the activate integration tests seem to be
+			// affected by a write to os.Stderr. Regardless, since state-svc runs in the background for
+			// the most part, we realistically will not see this error.
+			//fmt.Fprintf(os.Stderr, "Warning: failed to wait for events")
 		}
 		os.Exit(exitCode)
 	}()

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,10 @@ func main() {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`if err := events.WaitForEvents(5*time.Second, rollbar.Wait, authentication.LegacyClose, logging.Close); err != nil {`
`58`		`- fmt.Fprintf(os.Stderr, "Warning: failed to wait for events")`
	`58`	`+ // Note: logger is closed, so cannot log here. Also, the activate integration tests seem to be`
	`59`	`+ // affected by a write to os.Stderr. Regardless, since state-svc runs in the background for`
	`60`	`+ // the most part, we realistically will not see this error.`
	`61`	`+ //fmt.Fprintf(os.Stderr, "Warning: failed to wait for events")`
`59`	`62`	`}`
`60`	`63`	`os.Exit(exitCode)`
`61`	`64`	`}()`