Skip to content

Commit 1e74097

Browse files
committed
Switch Expat to the AS Platform Expat
1 parent 132b6a0 commit 1e74097

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

PCbuild/pyexpat.vcxproj

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,21 @@
6161
<AdditionalIncludeDirectories>$(PySourcePath)Modules\expat;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
6262
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;PYEXPAT_EXPORTS;XML_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
6363
</ClCompile>
64+
<Link>
65+
<AdditionalDependencies>$(expatLibDir)\libexpat.lib</AdditionalDependencies>
66+
<!-- <AdditionalLibraryDirectories Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(OutDir);%(AdditionalLibraryDirectories);$(zlibLibDir)</AdditionalLibraryDirectories> -->
67+
<BaseAddress>0x1e000000</BaseAddress>
68+
</Link>
6469
</ItemDefinitionGroup>
65-
<ItemGroup>
66-
<ClInclude Include="..\Modules\expat\xmlrole.h" />
67-
<ClInclude Include="..\Modules\expat\xmltok.h" />
68-
</ItemGroup>
70+
<!-- <ItemGroup> -->
71+
<!-- <ClInclude Include="..\Modules\expat\xmlrole.h" /> -->
72+
<!-- <ClInclude Include="..\Modules\expat\xmltok.h" /> -->
73+
<!-- </ItemGroup> -->
6974
<ItemGroup>
7075
<ClCompile Include="..\Modules\pyexpat.c" />
71-
<ClCompile Include="..\Modules\expat\xmlparse.c" />
72-
<ClCompile Include="..\Modules\expat\xmlrole.c" />
73-
<ClCompile Include="..\Modules\expat\xmltok.c" />
76+
<!-- <ClCompile Include="..\Modules\expat\xmlparse.c" /> -->
77+
<!-- <ClCompile Include="..\Modules\expat\xmlrole.c" /> -->
78+
<!-- <ClCompile Include="..\Modules\expat\xmltok.c" /> -->
7479
</ItemGroup>
7580
<ItemGroup>
7681
<ProjectReference Include="pythoncore.vcxproj">

PCbuild/python.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
<zlibDir Condition="!HasTrailingSlash($(zlibDir))">$(zlibDir)\</zlibDir>
6565
<zlibIncludeDir>$(zlibDir)include</zlibIncludeDir>
6666
<zlibLibDir>$(zlibDir)lib</zlibLibDir>
67-
67+
<!-- Expat library directory that ActiveState provides -->
68+
<expatLibDir>$(AS_DEPENDENCIES_DIR)/lib</expatLibDir>
6869
<!-- Suffix for all binaries when building for debug -->
6970
<PyDebugExt Condition="'$(PyDebugExt)' == '' and $(Configuration) == 'Debug'">_d</PyDebugExt>
7071

0 commit comments

Comments
 (0)