Skip to content

Commit 293f574

Browse files
committed
fix test parameters
1 parent 535c123 commit 293f574

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/test_mtc.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ def regress(ext, out_dir):
229229
@pytest.mark.parametrize(
230230
"chunk_training_mode,recode_pipeline_columns,sharrow_enabled",
231231
[
232-
("disabled", True),
233-
("explicit", False),
232+
("disabled", True, False),
233+
("explicit", False, False),
234234
("explicit", True, True),
235235
],
236236
)
@@ -275,8 +275,8 @@ def test_mtc_extended_progressive(chunk_training_mode, recode_pipeline_columns,
275275
raise ValueError("sharrow_enabled requires recode_pipeline_columns")
276276

277277
if sharrow_enabled:
278-
settings["sharrow"] = "test"
279-
del settings["trace_hh_id"]
278+
settings["sharrow"] = "test" # check sharrow in `test` mode
279+
del settings["trace_hh_id"] # do not test sharrow with tracing
280280

281281
state = workflow.State.make_default(
282282
working_dir=working_dir,
@@ -298,6 +298,8 @@ def test_mtc_extended_progressive(chunk_training_mode, recode_pipeline_columns,
298298
f"reference-pipeline-extended-recode{recode_pipeline_columns}.zip"
299299
)
300300
if not ref_pipeline.exists():
301+
# if reference pipeline does not exist, don't clean up so we can save
302+
# and create it at the end of running this test.
301303
state.settings.cleanup_pipeline_after_run = False
302304

303305
for step_name in EXPECTED_MODELS:

0 commit comments

Comments
 (0)