Skip to content

Commit 9991fce

Browse files
authored
release instructions (#927)
* use libmamba solver * add permissions [makedocs] * add write permission for dev docs [makedocs] * conda-solver: classic * include workflow dispatch option for tests * update release instructions * add installer build to instructions * Pin mamba for now, per conda-incubator/setup-miniconda#392 * conda-remove-defaults
1 parent 8e17c61 commit 9991fce

File tree

2 files changed

+51
-69
lines changed

2 files changed

+51
-69
lines changed

.github/workflows/core_tests.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ on:
88
pull_request:
99
branches:
1010
- '*'
11+
12+
workflow_dispatch:
1113

1214
env:
1315
CACHE_NUMBER: 0 # increase to reset cache manually
@@ -31,7 +33,9 @@ jobs:
3133
with:
3234
auto-update-conda: true
3335
miniforge-version: latest
36+
mamba-version: "2.0.5"
3437
conda-solver: classic
38+
conda-remove-defaults: true
3539
activate-environment: asim-test
3640
python-version: ${{ matrix.python-version }}
3741

@@ -116,7 +120,9 @@ jobs:
116120
with:
117121
auto-update-conda: true
118122
miniforge-version: latest
123+
mamba-version: "2.0.5"
119124
conda-solver: classic
125+
conda-remove-defaults: true
120126
activate-environment: asim-test
121127
python-version: ${{ matrix.python-version }}
122128

@@ -199,7 +205,9 @@ jobs:
199205
with:
200206
auto-update-conda: true
201207
miniforge-version: latest
208+
mamba-version: "2.0.5"
202209
conda-solver: classic
210+
conda-remove-defaults: true
203211
activate-environment: asim-test
204212
python-version: ${{ env.python-version }}
205213

@@ -287,7 +295,9 @@ jobs:
287295
with:
288296
auto-update-conda: true
289297
miniforge-version: latest
298+
mamba-version: "2.0.5"
290299
conda-solver: classic
300+
conda-remove-defaults: true
291301
activate-environment: asim-test
292302
python-version: ${{ env.python-version }}
293303

@@ -350,7 +360,9 @@ jobs:
350360
with:
351361
auto-update-conda: true
352362
miniforge-version: latest
363+
mamba-version: "2.0.5"
353364
conda-solver: classic
365+
conda-remove-defaults: true
354366
activate-environment: asim-test
355367
python-version: ${{ env.python-version }}
356368

@@ -402,7 +414,9 @@ jobs:
402414
with:
403415
auto-update-conda: true
404416
miniforge-version: latest
417+
mamba-version: "2.0.5"
405418
conda-solver: classic
419+
conda-remove-defaults: true
406420
activate-environment: asim-test
407421
python-version: ${{ env.python-version }}
408422

@@ -461,6 +475,8 @@ jobs:
461475
uses: conda-incubator/setup-miniconda@v3
462476
with:
463477
miniforge-version: latest
478+
mamba-version: "2.0.5"
479+
conda-remove-defaults: true
464480
environment-file: conda-environments/docbuild.yml
465481
python-version: "3.10"
466482
activate-environment: docbuild

HOW_TO_RELEASE.md

Lines changed: 35 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,28 @@
11
# How to issue an ActivitySim release
22

3-
> **WARNING: These instructions are incomplete.**
4-
5-
01. Check that the branch you intend to release is passing tests on Travis.
6-
If it's not passing there you should not release it.
3+
00. Check that the main branch is passing tests, especially the "core tests" on
4+
[GitHub Actions](https://github.com/ActivitySim/activitysim/actions/workflows/core_tests.yml).
5+
It is generally the policy that the main branch should always be passing tests,
6+
becuase PRs must pass tests before they can be merged. However, it is
7+
possible that tests may fail after a PR is merged, so it is important to
8+
double-check that the main branch is passing tests before issuing a release.
79

810
00. Start from a completely clean conda environment
911
and git repository. Assuming you have `conda` installed, you can do so
1012
by starting where ActivitySim is not yet cloned (e.g. in an empty
1113
directory) and running:
1214
```sh
13-
conda create -n TEMP-ASIM-DEV python=3.10 git gh -c conda-forge --override-channels
14-
conda activate TEMP-ASIM-DEV
15+
conda create -p ./TEMP-ASIM-DEV python=3.10 git gh -c conda-forge --override-channels
16+
conda activate ./TEMP-ASIM-DEV
1517
gh auth login # <--- (only needed if gh is not logged in)
1618
gh repo clone ActivitySim/activitysim
1719
cd activitysim
1820
```
1921

20-
00. Per project policy, code on the main branch should have been released,
21-
but if you are *preparing* a release then the code should be on the `develop`
22-
branch. Switch to that branch now, and make sure it is synced to the
23-
version on GitHub:
24-
```sh
25-
git switch develop
26-
git pull
27-
```
28-
2922
00. Update your Conda environment for testing. We do not want to use an
30-
existing environment on your machine, as it may be out-of-date
23+
existing environment on your machine, as it may be out-of-sync
3124
and we want to make sure everything passes muster using the
32-
most up-to-date dependencies available. The following command
25+
dependencies as they are available today. The following command
3326
will update the active environment (we made this to be `TEMP-ASIM-DEV`
3427
if you followed the directions above).
3528
```sh
@@ -48,7 +41,7 @@
4841
black --check --diff .
4942
```
5043

51-
00. Run the regular test suite on Windows. Most GitHub Actions tests are done on Linux,
44+
00. Run the regular test suite on Windows. Most GitHub Actions tests are done on
5245
Linux (it's faster to start up and run a new clean VM for testing) but most
5346
users are on Windows, and the test suite should also be run on Windows to
5447
ensure that it works on that platform as well. If you
@@ -67,7 +60,7 @@
6760
```
6861
6962
00. Test the full-scale regional examples. These examples are big, too
70-
large to run on Travis, and will take a lot of time (many hours) to
63+
large to run on GitHub Actions, and will take a lot of time (many hours) to
7164
download and run.
7265
```sh
7366
mkdir tmp-asim
@@ -88,75 +81,48 @@
8881
There are also demo notebooks for estimation, but their functionality
8982
is completely tested in the unit tests run previously.
9083

91-
00. Use bump2version to tag the release commit and update the
92-
version number. The following code will generate a "patch" release,
93-
incrementing the third value in the version number (i.e. "1.2.3"
94-
becomes "1.2.4"). Alternatively, make a "minor" or "major" release.
95-
The `--list` command will generate output to your console to confirm
96-
that the old and new version numbers are what you expect, before you
97-
push the commit (with the changed version in the code) and tags to
98-
GitHub.
99-
```sh
100-
bump2version patch --list
101-
```
102-
103-
It is also possible to make a development pre-release. To do so,
104-
explicitly set the version number to the next patch plus a ".devN"
105-
suffix:
106-
107-
```sh
108-
bump2version patch --new-version 1.2.3.dev0 --list
109-
```
110-
111-
Then, when ready to make a "final" release, set the version by
112-
explicitly removing the suffix:
84+
00. Tag the release commit with the new version number. ActivitySim uses
85+
dynamic versioning, so the version number is not stored in a file but
86+
is instead read from the most recent git tag, so it is important to tag
87+
the repository with the correct version. The following command will
88+
generate a new tag with the version number "1.2.3" (for example):
11389
```sh
114-
bump2version patch --new-version 1.2.3 --list
90+
git -a v1.2.3 -m "Release v1.2.3"
11591
```
11692

11793
00. Push the tagged commit to GitHub.
11894
```sh
11995
git push --tags
12096
```
12197

122-
00. For non-development releases, open a pull request to merge the proposed
123-
release into main. The following command will open a web browser for
124-
you to create the pull request.
125-
```sh
126-
gh pr create --web
127-
```
128-
After creating the PR, confirm with the ActivitySim PMC that the release
129-
is ready before actually merging it.
130-
131-
Once final approval is granted, merge the PR into main. The presence
132-
of the git tags added earlier will trigger automated build steps to
133-
prepare and deploy the release to pypi and conda-forge.
134-
135-
00. Create a "release" on GitHub.
98+
00. Create a "release" on GitHub. You can do this from the command line using
99+
the `gh` command line tool:
136100
```sh
137101
gh release create v1.2.3
138102
```
103+
But it may be easier to do this through the
104+
[GitHub web interface](https://github.com/ActivitySim/activitysim/releases/new),
105+
where you can select the tag you just created and add a title and description.
106+
Both the interactive command line tool shown above and the web interface include
107+
the ability to create release notes automatically from the commit messages of
108+
all accepted PRs since the last release, but you may want to add additional
109+
notes to the release to highlight important changes or new features.
110+
139111
The process of creating and tagging a release will automatically
140112
trigger various GitHub Actions scripts to build, test, and publish the
141113
new release to PyPI and conda forge, assuming there are no errors.
142114

143-
For a development pre-release, include the `--prerelease` argument.
144-
As the project's policy is that only formally released code is merged
145-
to the main branch, any pre-release should also be built against a
146-
non-default branch. For example, to pre-release from the `develop`
147-
branch:
148-
```sh
149-
gh release create v1.2.3.dev0 \
150-
--prerelease \
151-
--target develop \
152-
--notes "this pre-release is for a cool new feature" \
153-
--title "Development Pre-Release"
154-
```
115+
00. Build the ActivitySim Standalone Windows Installer. This is done using
116+
GitHub Actions, but it is not done automatically when a release is created,
117+
instead it requires a manual workflow dispatch trigger. You can do this by
118+
going to the [build_installer workflow page](https://github.com/ActivitySim/activitysim/actions/workflows/build_installer.yml)
119+
and clicking on the "Run workflow" button. You will need to provide the
120+
version number and choose to add the built installer to the release.
155121

156122
00. Clean up your workspace, including removing the Conda environment used for
157123
testing (which will prevent you from accidentally using an old
158124
environment when you should have a fresh up-to-date one next time).
159125
```sh
160126
conda deactivate
161-
conda env remove -n TEMP-ASIM-DEV
127+
conda env remove -p ./TEMP-ASIM-DEV
162128
```

0 commit comments

Comments
 (0)