-
Notifications
You must be signed in to change notification settings - Fork 118
Contribution Review
When contributing to ActivitySim, the set of questions below will be asked of the contribution. Make sure to also review the Development documentation before making a submittal. The automated test system also provides some helpful information where identified.
To submit a contribution for review, issue a pull request with a comment introducing your contribution. The comment should include a brief overview, responses to the questions, and pointers to related information. The entire submittal should ideally be self contained so any additional documentation should be in the pull request as well. The PMC will handle the review request, comment on each question, complete the feedback form, and reply to the pull request. Its a good idea to setup a pre-submittal meeting to discuss questions and better understand expectations.
- ?
- ?
- ?
- ?
- ?
- ?
- ?
- ?
- ?
- ?
The PMC will provide feedback for each review criteria above and tag each submittal category as follows:
| Status | Code | Documentation | Tests/Examples |
|---|---|---|---|
| Accept | |||
| Accept but recommend revisions | |||
| Do not accept | |||
| Abstain |