feat: modules exit after SIGKILL of app#191
Merged
0xbrayo merged 2 commits intoActivityWatch:masterfrom Jan 14, 2026
Merged
Conversation
Member
Author
|
Haven't tested on Windows yet |
44008ff to
4cd0558
Compare
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 4cd0558 in 2 minutes and 29 seconds. Click for details.
- Reviewed
366lines of code in3files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/manager.rs:728
- Draft comment:
In the aw-notify thread, after manually reading stdout via BufReader (lines ~730–760), the call to wait_with_output may yield an Output with empty stdout since it was already consumed. Verify this is intended for logging purposes. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. src-tauri/src/manager.rs:490
- Draft comment:
There is duplicated logic between start_generic_module_thread and start_notify_module_thread. Consider refactoring shared code to improve maintainability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. src-tauri/src/manager.rs:497
- Draft comment:
The error message on line 497 uses the placeholder{name}. Please verify if this is intentional, as it doesn't appear to interpolate a variable. If no variable is intended, consider removing or correcting the placeholder. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_Nb3Zc3XY6QalqJdy
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Member
Author
|
Tested on windows, works perfectly |
4cd0558 to
c2a73b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
Important
Ensure child processes terminate with parent using job objects on Windows and pipes on Unix in
manager.rs.create_job_object()inmanager.rscreates a job object to ensure child processes are killed when the parent is terminated.monitor_parent_process()inmanager.rsuses a pipe to detect parent process termination and sendsSIGTERMto child processes.libctoCargo.tomlfor Unix-specific functionality.winapifeatures inCargo.tomlto includejobapi2,handleapi,processthreadsapi, andwinntfor job object management.start_generic_module_thread()andstart_notify_module_thread()inmanager.rs.This description was created by
for 4cd0558. You can customize this summary. It will automatically update as commits are pushed.