Skip to content

feat: exponential backoff delay when restaring modules#193

Merged
0xbrayo merged 1 commit intoActivityWatch:masterfrom
0xbrayo:exponential-backoff
Jan 15, 2026
Merged

feat: exponential backoff delay when restaring modules#193
0xbrayo merged 1 commit intoActivityWatch:masterfrom
0xbrayo:exponential-backoff

Conversation

@0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Jan 15, 2026

Important

Implements exponential backoff for module restarts in manager.rs, delaying restarts by 2, 4, and 8 seconds for the first three attempts.

  • Behavior:
    • Implements exponential backoff for module restarts in handle() in manager.rs.
    • Modules now restart with delays of 2, 4, and 8 seconds for the first three attempts.
    • After three failed attempts, modules are marked for shutdown and not restarted.
  • Logging:
    • Logs restart attempts and delays in handle().
    • Logs when restart limit is reached and module is not restarted.

This description was created by Ellipsis for de477d2. You can customize this summary. It will automatically update as commits are pushed.

@0xbrayo
Copy link
Member Author

0xbrayo commented Jan 15, 2026

Closes #192

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to de477d2 in 2 minutes and 14 seconds. Click for details.
  • Reviewed 131 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/manager.rs:409
  • Draft comment:
    The log message uses a mix of named and positional placeholders. Consider using a consistent formatting style for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. src-tauri/src/manager.rs:392
  • Draft comment:
    The state lock is acquired multiple times in this block. Consider refactoring to reduce redundant locking for better clarity and potential performance improvements.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_EkxvXgZdX2VOdi5V

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@0xbrayo 0xbrayo force-pushed the exponential-backoff branch from de477d2 to e5db4fb Compare January 15, 2026 15:28
@0xbrayo 0xbrayo force-pushed the exponential-backoff branch from e5db4fb to 4e11034 Compare January 15, 2026 15:59
@0xbrayo 0xbrayo merged commit 07a2acf into ActivityWatch:master Jan 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant