feat: exponential backoff delay when restaring modules#193
Merged
0xbrayo merged 1 commit intoActivityWatch:masterfrom Jan 15, 2026
Merged
feat: exponential backoff delay when restaring modules#1930xbrayo merged 1 commit intoActivityWatch:masterfrom
0xbrayo merged 1 commit intoActivityWatch:masterfrom
Conversation
Member
Author
|
Closes #192 |
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to de477d2 in 2 minutes and 14 seconds. Click for details.
- Reviewed
131lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/manager.rs:409
- Draft comment:
The log message uses a mix of named and positional placeholders. Consider using a consistent formatting style for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src-tauri/src/manager.rs:392
- Draft comment:
The state lock is acquired multiple times in this block. Consider refactoring to reduce redundant locking for better clarity and potential performance improvements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_EkxvXgZdX2VOdi5V
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
de477d2 to
e5db4fb
Compare
e5db4fb to
4e11034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Implements exponential backoff for module restarts in
manager.rs, delaying restarts by 2, 4, and 8 seconds for the first three attempts.handle()inmanager.rs.handle().This description was created by
for de477d2. You can customize this summary. It will automatically update as commits are pushed.