fix: improved content & design of consent dialog

ErikBjare · ErikBjare · commit 993f7e06bb92 · 2023-03-06T16:13:42.000+01:00
diff --git a/src/eventPage.js b/src/eventPage.js
@@ -182,7 +182,7 @@ function startPopupListener() {
         chrome.storage.local.get("askConsent", (obj) => {
           if(obj.askConsent) {
             const url = chrome.runtime.getURL("../static/consent.html");
-            chrome.windows.create({ url, type: "popup", height: 420, width: 416, });
+            chrome.windows.create({ url, type: "popup", height: 550, width: 416, });
             freshInstall = false;
           }
         })
diff --git a/static/consent.html b/static/consent.html
@@ -10,19 +10,35 @@
 </head>
 
 <body class="consent">
-  <img src="/media/banners/banner.png" style="width: 100%">
+  <img src="/media/banners/banner.png" style="width: 100%" />
 
-  <hr>
+  <h1 style="text-align: center; margin-bottom: 0">Privacy Notice</h1>
+  <h3 style="text-align: center; margin-top: 0">and your consent</h3>
+
+  <!-- This box border helps highlight that there is more text if the box is cut off by a small window -->
+  <div style="text-overflow: scroll; border: 2px solid #DDD; border-radius: 2px; margin: 0.5em; padding: 0 0.5em 0 0.5em;">
+    <p>
+      This extension collects information about the active tab, such as its title, URL, wether it is audible, or incognito/private.
+    </p>
+
+    <p>
+      It stores that information in your locally installed ActivityWatch instance, which is required for the functioning of this extension.
+      It is never sent elsewhere than to the local device.
+    </p>
+
+    <p>
+      Due to Mozilla policy, we need to ask for your consent before we can start collecting this information, even if only kept locally.
+    </p>
+
+    <p>
+      Since this is the core functionality of this extension, if you do not consent, your only course of action is to uninstall.
+    </p>
+  </div>
 
-  <h1>Privacy Notice</h1>
-  <p>
-    This extension by nature collects personal identifiable information in the form of URLs. All collected information never leaves your device because all data is only forwarded to localhost. Since this is the core functionality of this extension, the only option to not consent, is to uninstall.
-  </p>
   <div class="action-container">
-    <div class="action"><button class="button" id="consent-refused">Remove ActivityWatch</button></div>
+    <div class="action"><button class="button" id="consent-refused">Remove ActivityWatch extension</button></div>
     <div class="action"><button class="button accept" id="consent-given">Consent to offline data collection</button></div>
   </div>
-
 </body>
 
 </html>
diff --git a/static/popup.js b/static/popup.js
@@ -51,7 +51,7 @@ function domListeners() {
   let consent_button = document.getElementById('status-consent-btn');
   consent_button.addEventListener('click', () => {
     const url = chrome.runtime.getURL("../static/consent.html");
-    chrome.windows.create({ url, type: "popup", height: 420, width: 416, });
+    chrome.windows.create({ url, type: "popup", height: 550, width: 416, });
   });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ function startPopupListener() {`
`182`	`182`	`chrome.storage.local.get("askConsent", (obj) => {`
`183`	`183`	`if(obj.askConsent) {`
`184`	`184`	`const url = chrome.runtime.getURL("../static/consent.html");`
`185`		`- chrome.windows.create({ url, type: "popup", height: 420, width: 416, });`
	`185`	`+ chrome.windows.create({ url, type: "popup", height: 550, width: 416, });`
`186`	`186`	`freshInstall = false;`
`187`	`187`	`}`
`188`	`188`	`})`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ function domListeners() {`
`51`	`51`	`let consent_button = document.getElementById('status-consent-btn');`
`52`	`52`	`consent_button.addEventListener('click', () => {`
`53`	`53`	`const url = chrome.runtime.getURL("../static/consent.html");`
`54`		`- chrome.windows.create({ url, type: "popup", height: 420, width: 416, });`
	`54`	`+ chrome.windows.create({ url, type: "popup", height: 550, width: 416, });`
`55`	`55`	`});`
`56`	`56`	`}`
`57`	`57`