-
-
Notifications
You must be signed in to change notification settings - Fork 129
Description
I'd like to implement a feature, to make the timline box title configurable.
I'd like to see the "title" property for the "aw-watcher". I see that the logic in the getTitleAttr is hardcoded and relies on magic knowledge about the type of the bucket.
I see three options to implement this
Option 1
If type is currentWindow, user can specify in the settings page, which field should be shown. The setting would be stored in the localStorage and can be read in the getTitleAttr method.
Pro:
- very easy implementation
Con: - it's global, so it applies to all the watchers
- it's only working for the type 'currentWindow'
Option 2
Add a setting per watcher to control, what property should be shown and store that in the localstorage. A new UI concept (modal dialog?) is needed on the timeline page (clicking opens a popup where you can control the display value)
Pro:
- Finegrained control
- works for every watcher type
Con:
- More effort
- if several watchers of the same type are shown, you can't change them all at once
Option 3
Add a setting on the settings page, where we list all the watcher types. For each watcher type, you can override the display property
Pro:
- Finegrained control
- Feels like the best solution for the user
Con:
- even more effort, since we need to display a list of all used watcher types (and this might change over time)
Which option would be the best for you?
