Skip to content

Commit 1d66c4c

Browse files
committed
Updated: "in derived classes, super() should be called before" (nervgh#492)
1 parent dd0fd26 commit 1d66c4c

File tree

6 files changed

+48
-31
lines changed

6 files changed

+48
-31
lines changed

dist/angular-file-upload.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-file-upload.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-file-upload",
3-
"version": "2.1.2",
3+
"version": "2.1.3",
44
"homepage": "https://github.com/nervgh/angular-file-upload",
55
"description": "Angular File Upload is a module for the AngularJS framework",
66
"author": {

src/services/FileDrop.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import CONFIG from './../config.json';
55

66

77
let {
8+
extend,
89
forEach
910
} = angular;
1011

@@ -19,17 +20,19 @@ export default (FileDirective) => {
1920
* @constructor
2021
*/
2122
constructor(options) {
22-
// Map of events
23-
this.events = {
24-
$destroy: 'destroy',
25-
drop: 'onDrop',
26-
dragover: 'onDragOver',
27-
dragleave: 'onDragLeave'
28-
};
29-
// Name of property inside uploader._directive object
30-
this.prop = 'drop';
23+
let extendedOptions = extend(options, {
24+
// Map of events
25+
events: {
26+
$destroy: 'destroy',
27+
drop: 'onDrop',
28+
dragover: 'onDragOver',
29+
dragleave: 'onDragLeave'
30+
},
31+
// Name of property inside uploader._directive object
32+
prop: 'drop'
33+
});
3134

32-
super(options);
35+
super(extendedOptions);
3336
}
3437
/**
3538
* Returns options

src/services/FileOver.js

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
import CONFIG from './../config.json';
55

66

7+
let {
8+
extend
9+
} = angular;
10+
11+
712
export default (FileDirective) => {
813

914

@@ -14,16 +19,18 @@ export default (FileDirective) => {
1419
* @constructor
1520
*/
1621
constructor(options) {
17-
// Map of events
18-
this.events = {
19-
$destroy: 'destroy'
20-
};
21-
// Name of property inside uploader._directive object
22-
this.prop = 'over';
23-
// Over class
24-
this.overClass = 'nv-file-over';
22+
let extendedOptions = extend(options, {
23+
// Map of events
24+
events: {
25+
$destroy: 'destroy'
26+
},
27+
// Name of property inside uploader._directive object
28+
prop: 'over',
29+
// Over class
30+
overClass: 'nv-file-over'
31+
});
2532

26-
super(options);
33+
super(extendedOptions);
2734
}
2835
/**
2936
* Adds over class

src/services/FileSelect.js

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
import CONFIG from './../config.json';
55

66

7+
let {
8+
extend
9+
} = angular;
10+
11+
712
export default (FileDirective) => {
813

914

@@ -14,15 +19,17 @@ export default (FileDirective) => {
1419
* @constructor
1520
*/
1621
constructor(options) {
17-
// Map of events
18-
this.events = {
19-
$destroy: 'destroy',
20-
change: 'onChange'
21-
};
22-
// Name of property inside uploader._directive object
23-
this.prop = 'select';
22+
let extendedOptions = extend(options, {
23+
// Map of events
24+
events: {
25+
$destroy: 'destroy',
26+
change: 'onChange'
27+
},
28+
// Name of property inside uploader._directive object
29+
prop: 'select'
30+
});
2431

25-
super(options);
32+
super(extendedOptions);
2633

2734
if(!this.uploader.isHTML5) {
2835
this.element.removeAttr('multiple');

0 commit comments

Comments
 (0)