Skip to content

Include expression type into expression comparison #1236

@jklmnn

Description

@jklmnn

Currently expressions are compared by str(self) == str(other). While this resulted from an efficiency improvement before the introduction of type checking it may now lead to passing tests even when errors in the type setting or checking are present.

This ticket is small as adding the expression type to the comparison makes very few tests fail, most of them due to types that are not set when comparing a structure from a message with a custom structure without a message.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmodelRelated to model package (e.g., model verification)refactoringsmallEffort of one person-day or less

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions