Merge branch 'topic/#1663' into 'master'

Remove .gnatdebug support in the ALS

See merge request eng/ide/ada_language_server!2013

Author: AnthonyLeonardoGracio

source/ada/lsp-ada_driver.adb

@@ -342,8 +342,6 @@ procedure LSP.Ada_Driver is
 
    ALS_Log_Dir                : Virtual_File := LSP.Env.ALS_Log_Dir;
    Clean_ALS_Dir          : Boolean := False;
-   GNATdebug              : constant Virtual_File := Create_From_Base
-     (".gnatdebug");
 
    Traces_File : Virtual_File;
 
@@ -424,7 +422,6 @@ begin
    begin
       --  Look for a traces file, in this order:
       --     - passed on the command line via --tracefile,
-      --     - in a .gnatdebug file locally
       --     - in "traces.cfg" in the ALS home directory
       if VSS.Command_Line.Is_Specified (Trace_File_Option) then
          Traces_File :=
@@ -436,8 +433,6 @@ begin
             GNAT.OS_Lib.OS_Exit (1);
          end if;
 
-      elsif GNATdebug.Is_Regular_File then
-         Traces_File := GNATdebug;
       else
          --  No $HOME/.als directory: create one first
          if not ALS_Log_Dir.Is_Directory then

testsuite/ada_lsp/als.1663.no_crash_when_gnatdebug/.gnatdebug

@@ -0,0 +1,4 @@
+# .gnatdebug file that makes the ALS to crash when parsed, since
+# it emits logs directly on the standard output
++
+PROCESS_MANAGER=yes

testsuite/ada_lsp/als.1663.no_crash_when_gnatdebug/test.json

@@ -0,0 +1,91 @@
+[
+   {
+      "comment": [
+         "This test just checks that the ALS does not crash in presence of ",
+         "a .gnatdebug file in the working directory"
+      ]
+   },
+   {
+      "start": {
+         "cmd": ["${ALS}"]
+      }
+   },
+   {
+      "send": {
+         "request": {
+            "params": {
+               "capabilities": {
+                  "workspace": {
+                     "applyEdit": false
+                  }
+               },
+               "rootUri": "$URI{.}"
+            },
+            "jsonrpc": "2.0",
+            "id": 1,
+            "method": "initialize"
+         },
+         "wait": [
+            {
+               "id": 1,
+               "result": {
+                  "capabilities": {
+                     "textDocumentSync": 2,
+                     "signatureHelpProvider": {
+                        "triggerCharacters": [",", "("],
+                        "retriggerCharacters": ["\b"]
+                     }
+                  }
+               }
+            }
+         ]
+      }
+   },
+   {
+      "send": {
+         "request": {
+            "jsonrpc": "2.0",
+            "method": "initialized"
+         },
+         "wait": []
+      }
+   },
+   {
+      "send": {
+         "request": {
+            "jsonrpc": "2.0",
+            "method": "workspace/didChangeConfiguration",
+            "params": {
+               "settings": {
+                  "ada": {
+                     "defaultCharset": "ISO-8859-1",
+                     "projectFile": "$URI{default.gpr}",
+                     "scenarioVariables": {}
+                  }
+               }
+            }
+         },
+         "wait": []
+      }
+   },
+   {
+      "send": {
+         "request": {
+            "jsonrpc": "2.0",
+            "id": 8,
+            "method": "shutdown"
+         },
+         "wait": [
+            {
+               "id": 8,
+               "result": null
+            }
+         ]
+      }
+   },
+   {
+      "stop": {
+         "exit_code": 0
+      }
+   }
+]

testsuite/ada_lsp/als.1663.no_crash_when_gnatdebug/test.yaml

@@ -0,0 +1 @@
+title: 'als.1663.no_crash_when_gnatdebug'