Merge remote branch 'origin/master' into edge

(no-precommit-check no-tn-check)

Author: mergerepo

source/ada/lsp-ada_completions-names.adb

@@ -39,6 +39,7 @@ package body LSP.Ada_Completions.Names is
    is
       use all type Libadalang.Analysis.Base_Id;
       use all type Libadalang.Common.Ada_Node_Kind_Type;
+      use type Libadalang.Common.Token_Kind;
 
       Parent   : Libadalang.Analysis.Ada_Node;
       --  The parent of the node to complete.
@@ -50,6 +51,21 @@ package body LSP.Ada_Completions.Names is
 
       Use_Snippets : Boolean := Self.Snippets_Enabled;
 
+      --  Error recovery for Obj.XXX with XXX a keyword => LAL will often
+      --  consider it as:
+      --  - CallStmt
+      --     - Dotted_Name
+      --  - ErrorStmt/LoopStmt/etc.
+      Error_Dotted_Recovery : constant Boolean :=
+        Libadalang.Analysis.Is_Keyword
+          (Token   => Token,
+           Version => Libadalang.Common.Ada_2012)
+        and then
+          Libadalang.Common.Kind
+            (Libadalang.Common.Data
+               (Libadalang.Common.Previous
+                  (Token, Exclude_Trivia => True)))
+          = Libadalang.Common.Ada_Dot;
    begin
       --  Get the outermost dotted name of which node is a prefix, so that when
       --  completing in a situation such as the following:
@@ -172,7 +188,7 @@ package body LSP.Ada_Completions.Names is
 
                      Names.Include
                        (DN.P_Canonical_Part,
-                        (Is_Dot_Call (Item),
+                        (Error_Dotted_Recovery or else Is_Dot_Call (Item),
                          Is_Visible (Item),
                          Use_Snippets,
                          Completion_Count,

testsuite/ada_lsp/completion.dotted_call.keyword/bar.ads

@@ -0,0 +1,9 @@
+package Bar is
+
+   type My_Int is tagged record
+      A : Integer;
+   end record;
+
+   procedure Do_Nothing (Obj : My_Int; A :Integer; B : Integer) is null;
+
+end Bar;

testsuite/ada_lsp/completion.dotted_call.keyword/default.gpr

@@ -0,0 +1,5 @@
+project Default is
+
+   for Languages use ("Ada");
+   for Main use ("main.adb");
+end Default;

testsuite/ada_lsp/completion.dotted_call.keyword/main.adb

@@ -0,0 +1,8 @@
+with Bar; use Bar;
+with Ada.Text_IO;
+
+procedure Main is
+   Obj : My_Int := (A => 10);
+begin
+   Obj.
+end Main;