Move indexing after didChange to a job but still reparse the AU

The indexing after didChange is a job which is increasing the IDs
for the next requests. Disable this indexing via a trace for the
testsuites.

Index the runtime only after loading the project

Author: Boulanger

source/ada/lsp-ada_contexts.adb

@@ -958,16 +958,17 @@ package body LSP.Ada_Contexts is
    -----------------------------
 
    function Project_Attribute_Value
-     (Self         : Context;
-      Attribute    : GPR2.Q_Attribute_Id;
-      Index        : String := "";
-      Default      : String := "") return String is
+     (Self      : Context;
+      Attribute : GPR2.Q_Attribute_Id;
+      Index     : String := "";
+      Default   : String := "") return String is
    begin
-      return Project_Attribute_Value
-        (View         => Self.Tree.Root_Project,
-         Attribute    => Attribute,
-         Index        => Index,
-         Default      => Default);
+      return
+        Project_Attribute_Value
+          (View      => Self.Tree.Root_Project,
+           Attribute => Attribute,
+           Index     => Index,
+           Default   => Default);
    end Project_Attribute_Value;
 
 end LSP.Ada_Contexts;

source/ada/lsp-ada_did_change_document.adb

@@ -15,15 +15,22 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
+with GNATCOLL.Traces; use GNATCOLL.Traces;
 with GNATCOLL.VFS;
 
+with Libadalang;
+with Libadalang.Analysis;
 with LSP.Ada_Documents;
 with LSP.Client_Message_Receivers;
 with LSP.Structures;
 with LSP.Server_Notifications.DidChange;
 
 package body LSP.Ada_Did_Change_Document is
 
+   Did_Change_Indexing : constant Trace_Handle :=
+     Create ("ALS.DID_CHANGE.INDEXING", On);
+   --  Should be disabled when running the testsuite
+
    type Did_Change_Job
      (Parent : not null access constant Ada_Did_Change_Handler)
    is limited new LSP.Server_Jobs.Server_Job with record
@@ -101,9 +108,22 @@ package body LSP.Ada_Did_Change_Document is
            (Message.Params.textDocument.version, Changes);
       end if;
 
+      --  Clear the cacha of symbols now
+      LSP.Ada_Documents.Reset_Symbol_Cache (Self.Document.all);
+      --  Manually reparse the file in all context now so the AU is up-to-date
+      --  for the following requests.
       for Context of Self.Parent.Context.Contexts_For_File (File) loop
-         Context.Index_Document (Self.Document.all);
+         declare
+            Dummy : Libadalang.Analysis.Analysis_Unit;
+         begin
+            Dummy := Context.Get_AU (File, Reparse => True);
+         end;
       end loop;
+      --  The indexing here will do PLE and fill the database of Defining_Name
+      --  in a separate job at the lowest priority
+      if Did_Change_Indexing.Is_Active then
+         Self.Parent.Context.Enqueue_Indexing (File);
+      end if;
 
       --  Emit diagnostics
       Self.Parent.Context.Publish_Diagnostics (Self.Document);

source/ada/lsp-ada_formatter.adb

@@ -40,7 +40,7 @@ package body LSP.Ada_Formatter is
      (Parent : not null access constant Ada_Range_Formatter_Handler)
    is limited
      new LSP.Ada_Request_Jobs.Ada_Request_Job
-          (Priority => LSP.Server_Jobs.Fence)
+          (Priority => LSP.Server_Jobs.High)
    with null record;
 
    type Ada_Range_Formatter_Job_Access is access all Ada_Range_Formatter_Job;
@@ -56,7 +56,7 @@ package body LSP.Ada_Formatter is
      (Parent : not null access constant Ada_On_Type_Formatter_Handler)
    is limited
      new LSP.Ada_Request_Jobs.Ada_Request_Job
-          (Priority => LSP.Server_Jobs.Fence)
+          (Priority => LSP.Server_Jobs.High)
    with null record;
 
    type Ada_On_Type_Formatter_Job_Access is

source/ada/lsp-ada_handlers-project_loading.adb

@@ -808,7 +808,8 @@ package body LSP.Ada_Handlers.Project_Loading is
          Handler       => Self'Unchecked_Access,
          Configuration => Self.Configuration,
          Project_Stamp => Self.Project_Stamp,
-         Files         => Files);
+         Files         => Files,
+         Index_Runtime => True);
    end Enqueue_Indexing_Job;
 
    ---------------------------------------

source/ada/lsp-ada_handlers.adb

@@ -24,6 +24,7 @@ with Ada.Unchecked_Deallocation;
 with GNAT.OS_Lib;
 
 with LAL_Refactor.Sort_Case;
+with LSP.Ada_Indexing;
 with LSP.Env;
 with VSS.Characters.Latin;
 with VSS.Strings;
@@ -356,6 +357,27 @@ package body LSP.Ada_Handlers is
       return Self.Contexts_For_File (File);
    end Contexts_For_Position;
 
+   ----------------------
+   -- Enqueue_Indexing --
+   ----------------------
+
+   overriding
+   procedure Enqueue_Indexing
+     (Self : in out Message_Handler;
+      File : GNATCOLL.VFS.Virtual_File)
+   is
+      Files : LSP.Ada_Indexing.File_Sets.Set;
+   begin
+      Files.Include (File);
+      LSP.Ada_Indexing.Schedule_Indexing
+        (Server        => Self.Server,
+         Handler       => Self'Unchecked_Access,
+         Configuration => Self.Configuration,
+         Project_Stamp => Self.Project_Stamp,
+         Files         => Files,
+         Index_Runtime => False);
+   end Enqueue_Indexing;
+
    ----------
    -- Free --
    ----------

source/ada/lsp-ada_handlers.ads

@@ -413,6 +413,11 @@ private
    --  When Force is True, the diagnostics will always be sent, regardless if
    --  they have changed or not.
 
+   overriding
+   procedure Enqueue_Indexing
+     (Self : in out Message_Handler; File : GNATCOLL.VFS.Virtual_File);
+   --  Reindex files and clear document.
+
    procedure Publish_Diagnostics
      (Self : in out Message_Handler; Force : Boolean := False);
    --  Publish workspace diagnostic messages.

source/ada/lsp-ada_indexing.adb

@@ -117,7 +117,10 @@ package body LSP.Ada_Indexing is
          Client.On_ProgressEnd_Work_Done
            (Self.Indexing_Token, (message => <>));
 
-         if Self.Handler.Project_Tree_Is_Aggregate then
+         if not Self.Handler.Is_Shutdown
+           and then Self.Index_Runtime
+           and then Self.Handler.Project_Tree_Is_Aggregate
+         then
             --  Add runtime to the invisible symbols for aggregate project
             declare
                use GPR2;
@@ -162,7 +165,8 @@ package body LSP.Ada_Indexing is
       Handler       : not null access LSP.Ada_Handlers.Message_Handler'Class;
       Configuration : LSP.Ada_Configurations.Configuration'Class;
       Project_Stamp : LSP.Ada_Handlers.Project_Stamp;
-      Files         : File_Sets.Set) is
+      Files         : File_Sets.Set;
+      Index_Runtime : Boolean) is
    begin
       if Files.Is_Empty
         or not Configuration.Indexing_Enabled
@@ -184,7 +188,8 @@ package body LSP.Ada_Indexing is
               Total_Files_Indexed  => 0,
               Total_Files_To_Index => Natural (Files.Length),
               Progress_Report_Sent => Ada.Calendar.Clock,
-              Project_Stamp        => Project_Stamp);
+              Project_Stamp        => Project_Stamp,
+              Index_Runtime        => Index_Runtime);
 
       begin
          Server.On_Progress_Create_Request (Id, (token => Token));

source/ada/lsp-ada_indexing.ads

@@ -41,7 +41,8 @@ package LSP.Ada_Indexing is
       Handler       : not null access LSP.Ada_Handlers.Message_Handler'Class;
       Configuration : LSP.Ada_Configurations.Configuration'Class;
       Project_Stamp : LSP.Ada_Handlers.Project_Stamp;
-      Files         : File_Sets.Set);
+      Files         : File_Sets.Set;
+      Index_Runtime : Boolean);
 
    type Indexing_Job (<>) is new LSP.Server_Jobs.Server_Job
      with private;
@@ -82,6 +83,9 @@ private
       --  Time of send of last progress notification.
 
       Project_Stamp        : LSP.Ada_Handlers.Project_Stamp;
+
+      Index_Runtime        : Boolean := False;
+      --  True if the runtime should be indexed
    end record;
 
    overriding function Priority

source/ada/lsp-ada_job_contexts.ads

@@ -114,6 +114,10 @@ package LSP.Ada_Job_Contexts is
       Force             : Boolean := False) is abstract;
    --  Publish document diagnostics
 
+   procedure Enqueue_Indexing
+     (Self : in out Ada_Job_Context;
+      File : GNATCOLL.VFS.Virtual_File) is abstract;
+
    function Contexts_For_File
      (Self : Ada_Job_Context;
       File : GNATCOLL.VFS.Virtual_File)

testsuite/.als/ada_ls_traces.cfg

@@ -22,3 +22,7 @@ ALS.COMPLETION.FORMATTING=no
 
 # Disable logging in LSP formatting module
 ALS.FORMATTING=no
+
+# Disable indexing after didChange they are shifting the indexing for
+# refactoring requests
+ALS.DID_CHANGE.INDEXING=no