Merge branch 'mr/1622-fix-packaging-vscode-extension' into 'master'

Fix packaging for VS Code extension

See merge request eng/ide/ada_language_server!2073

Author: eliericha

integration/vscode/ada/.vscodeignore

@@ -3,7 +3,7 @@
 .vscode-test/
 advanced/
 node_modules/
-out/test/
+out/
 src/
 test/
 .eslintrc.json
@@ -19,4 +19,7 @@ vscode-test-win-workaround.py
 convert-mocha-junit-report.py
 unresolve.js
 !node_modules/@vscode/codicons/dist/codicon.css
-!node_modules/@vscode/codicons/dist/codicon.ttf
+!node_modules/@vscode/codicons/dist/codicon.ttf
+!out/src/visualizing/AppMain.js
+!out/src/extension.js
+!out/src/extension.js.map

integration/vscode/ada/CONTRIBUTING.md

@@ -14,6 +14,21 @@ cd integration/vscode/ada; npm install
 And then use the task `npm: compile` for compilation and the launch
 configuration `Launch Extension` for local testing and debugging.
 
+## Packaging
+
+The extension is packaged using vsce.
+
+When packaging, the npm script `vscode:prepublish` is called first which will in turn call scripts to bundle the code base.
+
+The project is composed of two different bundles:
+
+-   The script `esbuild-base` will generate the bundle `extension.js` that contains all the extension itself. This script uses esbuild which will take the Typescript sources, compile them and bundle them into a single file.
+-   The script `compile` will generate the bundle `AppMain.js` which serves as the entry point for the webViews generated by the extension. This script first compiles the Typescript sources using `tsc` separately and then uses `webpack` to bundle the resulting Javascript and CSS files.
+
+The two bundles need to stay separated as the second one needs to have a clear path different from the first one to be able to generate the HTML of the webViews of the extension.
+
+Finally, the two bundles are filtered in the `.vscodeignore` so that they are the only files added into the final package.
+
 ### macOS on Apple M1/M2 processors
 
 On macOS with Apple M1/M2 processors, using a native arm64 `node`/`npm` will
@@ -76,4 +91,4 @@ Furthermore, classifications within `repository` should be kept in alphabetical
 
 ## Final Notes
 
-Do not hesitate to ask for advice or help. *Any* working contributions are greatly appreciated.
+Do not hesitate to ask for advice or help. _Any_ working contributions are greatly appreciated.

integration/vscode/ada/package.json

@@ -1507,9 +1507,10 @@
     },
     "scripts": {
         "check-licenses": "npx license-checker-rseidelsohn --summary --onlyAllow \"0BSD;Apache-2.0;BSD-2-Clause;BSD-3-Clause;BlueOak-1.0.0;CC0-1.0;GPL-3.0;GPL-3.0-or-later;ISC;MIT;Python-2.0;Zlib;EPL-2.0\" --excludePackages \"@vscode/vsce-sign-linux-x64;@vscode/vsce-sign-win32-x64;@vscode/vsce-sign\"",
-        "vscode:prepublish": "npm run esbuild-base -- --minify --sourcemap",
+        "vscode:prepublish": "npm run compile && npm run esbuild-base -- --minify --sourcemap",
         "esbuild-base": "esbuild ./src/extension.ts --bundle --outfile=out/src/extension.js --external:vscode --format=cjs --platform=node",
-        "compile": "npm run copy && node ./node_modules/typescript/bin/tsc && webpack",
+        "compile": "node ./node_modules/typescript/bin/tsc && npm run compile-webview",
+        "compile-webview": "npm run copy && webpack",
         "watch": "npm run copy && node ./node_modules/typescript/bin/tsc -watch",
         "copy": "node -e \"fs.mkdirSync('out/src/visualizing', {recursive: true}); fs.copyFileSync('src/visualizing/visualizerStyleSheet.css','out/src/visualizing/visualizerStyleSheet.css')\"",
         "pretest": "npm run compile",