Merge branch 'topic/gnatcov' into 'master'

Slugify trace file names

See merge request eng/ide/ada_language_server!1948

Author: eliericha

integration/vscode/ada/src/gnattest.ts

@@ -9,7 +9,7 @@ import { CancellationToken } from 'vscode-languageclient';
 import { adaExtState } from './extension';
 import { addCoverageData, GnatcovFileCoverage } from './gnatcov';
 import { getScenarioArgs } from './gnatTaskProvider';
-import { escapeRegExp, exe, getObjectDir, setTerminalEnvironment } from './helpers';
+import { escapeRegExp, exe, getObjectDir, setTerminalEnvironment, slugify } from './helpers';
 import {
     DEFAULT_PROBLEM_MATCHER,
     findTaskByName,
@@ -609,7 +609,7 @@ async function handleRunRequestedTests(
         const tracesDir = path.dirname(execPath);
 
         function getTracePath(test: TestItem): string {
-            return path.join(tracesDir, test.id + '.srctrace');
+            return path.join(tracesDir, slugify(test.id) + '.srctrace');
         }
 
         /**

integration/vscode/ada/src/helpers.ts

@@ -627,3 +627,12 @@ export function staggerProgress(
         return lastProgress;
     }
 }
+
+/**
+ *
+ * @param arg - a string
+ * @returns a modified string suitable for use as a filename
+ */
+export function slugify(arg: string): string {
+    return arg.replace(/[<>:"/\\|?*]/g, '_');
+}

integration/vscode/ada/test/general/helpers.test.ts

@@ -4,6 +4,7 @@ import {
     findAdaMain,
     getSymbols,
     parallelize,
+    slugify,
     staggerProgress,
     which,
 } from '../../src/helpers';
@@ -343,4 +344,9 @@ suite('staggerProgress', function () {
         assert.ok(called, 'Progress reporting function was unexpectedly not called');
         assert.equal(lastProgress, 50);
     });
+
+    test('slugify', function () {
+        assert.equal(slugify('file<>:"/\\|?*name'), 'file_________name');
+        assert.equal(slugify('file<>:"/\\|?*name'), 'file' + '_'.repeat(9) + 'name');
+    });
 });