Manual cherry-pick of eng/ide/ada_language_server!1345

eng/ide/gnatstudio#85

Author: Boulanger

source/ada/lsp-ada_documents.adb

@@ -354,7 +354,7 @@ package body LSP.Ada_Documents is
 
                      Named_Template      : constant
                        VSS.Strings.Templates.Virtual_String_Template :=
-                         "{} => ${{{}:{} : {}{}}, ";
+                         "{} => ${{{}:{}{}}, ";
                      Positional_Template : constant
                        VSS.Strings.Templates.Virtual_String_Template :=
                          "${{{}:{} : {}{}}, ";
@@ -366,7 +366,6 @@ package body LSP.Ada_Documents is
                           Named_Template.Format
                             (LSP.Formatters.Texts.Image (Id.Text),
                              VSS.Strings.Formatters.Integers.Image (Idx),
-                             LSP.Formatters.Texts.Image (Id.Text),
                              LSP.Formatters.Texts.Image (Mode_Text),
                              LSP.Formatters.Texts.Image
                                (Param.F_Type_Expr.Text));

testsuite/ada_lsp/completion.param.threshold/test.json

@@ -169,20 +169,18 @@
                      {
                         "label": "Foo",
                         "kind": 3,
-                        "sortText": "100&1Foo",
+                        "sortText": "100&00001Foo",
                         "insertText": "Foo (S => ${1:String})$0",
                         "insertTextFormat": 2,
-                        "additionalTextEdits": [],
                         "detail": "procedure Foo (S : String)",
                         "documentation": "at pack.ads (4:4)"
                      },
                      {
                         "label": "Foo",
                         "kind": 3,
-                        "sortText": "100&2Foo",
+                        "sortText": "100&00002Foo",
                         "insertText": "Foo (I => ${1:Integer}, J => ${2:Integer})$0",
                         "insertTextFormat": 2,
-                        "additionalTextEdits": [],
                         "detail": "procedure Foo (I : Integer; J : Integer)",
                         "documentation": "at pack.ads (3:4)"
                      }