Merge branch 'topic/fix-gnattest-integration' into 'master'

Fix gnattest integration

Closes #1580

See merge request eng/ide/ada_language_server!1881

Author: eliericha

integration/vscode/ada/src/gnattest.ts

@@ -706,13 +706,23 @@ async function buildTestDriver(run: vscode.TestRun) {
      */
     const driverPrjPath = await getGnatTestDriverProjectPath();
     run.appendOutput(`Building the test harness project\r\n`);
-    const gprbuild = logAndRun(run, ['gprbuild', '-P', driverPrjPath, "'-cargs:ada'", '-gnatef']);
+    /**
+     * The following arguments are passed directly to the spawned subprocess.
+     * It not necessary nor appropriate to apply shell quoting here.
+     */
+    const gprbuild = logAndRun(run, ['gprbuild', '-P', driverPrjPath, '-cargs:ada', '-gnatef']);
 
     prepareAndAppendOutput(run, gprbuild.stdout.toLocaleString());
     prepareAndAppendOutput(run, gprbuild.stderr.toLocaleString());
 
     if (gprbuild.status !== 0) {
-        throw Error('Error while building the test driver');
+        throw Error(
+            'Error while building the test driver:\n' +
+                gprbuild.output
+                    .filter((x) => x != null)
+                    .map((x) => x.toLocaleString())
+                    .join('\n'),
+        );
     }
 }