Fix missing NotificationConfiguration for S3WebsiteDistribution

`S3WebsiteDistribution.add_cache_invalidation` is called after
`Bucket.resources` and so the `NotificationConfiguration` of the
bucket are missing from the stack template

Author: adanaja

src/e3/aws/troposphere/cloudfront/__init__.py

@@ -306,15 +306,17 @@ def resources(self, stack: Stack) -> list[AWSObject]:
         # Add bucket policy granting read access to te cloudfront distribution
         self.add_oai_access_to_bucket()
 
+        # Add a lambda invalidating cloudfront cache when bucket objects are modified
+        invalidation_resources = self.add_cache_invalidation(stack)
+
         result = [
             *(self.bucket.resources(stack) if self._create_bucket else []),
             self.cache_policy,
             self.distribution,
             self.origin_access_identity,
         ]
 
-        # Add a lambda invalidating cloudfront cache when bucket objects are modified
-        result.extend(self.add_cache_invalidation(stack))
+        result.extend(invalidation_resources)
 
         # Add route53 records if needed
         if self.r53_route_from:

tests/tests_e3_aws/troposphere/s3websitedistribution.json

@@ -1,8 +1,21 @@
 {
     "HostBucket": {
         "DeletionPolicy": "Retain",
+        "DependsOn": [
+            "TestS3wDistInvalidationTopicPolicy"
+        ],
         "Properties": {
             "BucketName": "host-bucket",
+            "NotificationConfiguration": {
+                "TopicConfigurations": [
+                    {
+                        "Event": "s3:ObjectCreated:*",
+                        "Topic": {
+                            "Ref": "TestS3wDistInvalidationTopic"
+                        }
+                    }
+                ]
+            },
             "BucketEncryption": {
                 "ServerSideEncryptionConfiguration": [
                     {

tests/tests_e3_aws/troposphere/s3websitedistribution_iam_path.json

@@ -1,8 +1,21 @@
 {
     "HostBucket": {
         "DeletionPolicy": "Retain",
+        "DependsOn": [
+            "TestS3wDistInvalidationTopicPolicy"
+        ],
         "Properties": {
             "BucketName": "host-bucket",
+            "NotificationConfiguration": {
+                "TopicConfigurations": [
+                    {
+                        "Event": "s3:ObjectCreated:*",
+                        "Topic": {
+                            "Ref": "TestS3wDistInvalidationTopic"
+                        }
+                    }
+                ]
+            },
             "BucketEncryption": {
                 "ServerSideEncryptionConfiguration": [
                     {

tests/tests_e3_aws/troposphere/s3websitedistribution_logging.json

@@ -1,8 +1,21 @@
 {
     "HostBucket": {
         "DeletionPolicy": "Retain",
+        "DependsOn": [
+            "TestS3wDistInvalidationTopicPolicy"
+        ],
         "Properties": {
             "BucketName": "host-bucket",
+            "NotificationConfiguration": {
+                "TopicConfigurations": [
+                    {
+                        "Event": "s3:ObjectCreated:*",
+                        "Topic": {
+                            "Ref": "TestS3wDistInvalidationTopic"
+                        }
+                    }
+                ]
+            },
             "BucketEncryption": {
                 "ServerSideEncryptionConfiguration": [
                     {

tests/tests_e3_aws/troposphere/s3websitedistribution_logging_default.json

@@ -1,8 +1,21 @@
 {
     "HostBucket": {
         "DeletionPolicy": "Retain",
+        "DependsOn": [
+            "TestS3wDistInvalidationTopicPolicy"
+        ],
         "Properties": {
             "BucketName": "host-bucket",
+            "NotificationConfiguration": {
+                "TopicConfigurations": [
+                    {
+                        "Event": "s3:ObjectCreated:*",
+                        "Topic": {
+                            "Ref": "TestS3wDistInvalidationTopic"
+                        }
+                    }
+                ]
+            },
             "BucketEncryption": {
                 "ServerSideEncryptionConfiguration": [
                     {

tests/tests_e3_aws/troposphere/s3websitedistribution_py313.json

@@ -1,8 +1,21 @@
 {
     "HostBucket": {
         "DeletionPolicy": "Retain",
+        "DependsOn": [
+            "TestS3wDistInvalidationTopicPolicy"
+        ],
         "Properties": {
             "BucketName": "host-bucket",
+            "NotificationConfiguration": {
+                "TopicConfigurations": [
+                    {
+                        "Event": "s3:ObjectCreated:*",
+                        "Topic": {
+                            "Ref": "TestS3wDistInvalidationTopic"
+                        }
+                    }
+                ]
+            },
             "BucketEncryption": {
                 "ServerSideEncryptionConfiguration": [
                     {