Merge branch 'morosi-feat' into 'master'

Add version argument to invoke_permission

See merge request it/e3-aws!64

Author: adanaja

src/e3/aws/troposphere/awslambda/__init__.py

@@ -262,6 +262,7 @@ def invoke_permission(
         service: str,
         source_arn: str,
         source_account: str | None = None,
+        version: Version | Alias | None = None,
     ) -> awslambda.Permission:
         """Create a Lambda Permission object for a given service.
 
@@ -271,11 +272,14 @@ def invoke_permission(
         :param source_account: account that holds the resource. This is
             mandatory only when using S3 as a service as a bucket arn is
             not linked to an account.
+        :param version: specific version or alias to give permission for
         :return: an AWSObject
         """
+        target = version if version is not None else self
+
         params = {
             "Action": "lambda:InvokeFunction",
-            "FunctionName": self.ref,
+            "FunctionName": target.ref,
             "Principal": f"{service}.amazonaws.com",
             "SourceArn": source_arn,
         }
@@ -284,7 +288,7 @@ def invoke_permission(
         if source_account is not None:
             params["SourceAccount"] = source_account
 
-        return awslambda.Permission(name_to_id(self.name + name_suffix), **params)
+        return awslambda.Permission(name_to_id(target.name + name_suffix), **params)
 
 
 class DockerFunction(Function):

tests/tests_e3_aws/troposphere/awslambda/awslambda_test.py

@@ -22,6 +22,7 @@
 from e3.aws import AWSEnv
 from e3.aws.troposphere import Stack
 from e3.aws.troposphere.awslambda import (
+    Function,
     PyFunction,
     Py38Function,
     DockerFunction,
@@ -1024,3 +1025,64 @@ def test_base64_response(base64_response_server: Flask) -> None:
     assert response["statusCode"] == 200
     assert response["headers"]["Content-Type"] == "image/png"
     assert response["body"] == "4pavUE5H4pCN4pCK4pCa4pCK"
+
+
+@pytest.mark.parametrize(
+    "version, expected_function_name_ref",
+    [
+        # Add the permission on the function itself
+        (
+            None,
+            "Mypylambda",
+        ),
+        # Add the permission on a version of the function
+        (
+            Version(
+                name="myversion", description="this is some version", lambda_arn=""
+            ),
+            "Myversion",
+        ),
+        # Add the permission on an alias of the function
+        (
+            Alias(
+                name="myalias",
+                description="this is some alias",
+                lambda_arn="",
+                lambda_version="",
+            ),
+            "Myalias",
+        ),
+    ],
+)
+def test_invoke_permission(
+    version: Version | Alias | None,
+    expected_function_name_ref: str,
+) -> None:
+    """Test Function.invoke_permission with various targets.
+
+    :param version: a version or alias of the function
+    :param expected_function_name_ref: name that should be referenced in FunctionName
+    """
+    function = Function(
+        name="mypylambda",
+        description="this is a test",
+        role="somearn",
+    )
+
+    permission = function.invoke_permission(
+        name_suffix="TopicName",
+        service="sns",
+        source_arn="arn:aws:sns:eu-west-1:123456789012:TopicName",
+        version=version,
+    )
+
+    assert permission.title == f"{expected_function_name_ref}TopicName"
+    assert permission.to_dict() == {
+        "Properties": {
+            "Action": "lambda:InvokeFunction",
+            "FunctionName": {"Ref": expected_function_name_ref},
+            "Principal": "sns.amazonaws.com",
+            "SourceArn": "arn:aws:sns:eu-west-1:123456789012:TopicName",
+        },
+        "Type": "AWS::Lambda::Permission",
+    }