Merge branch 'topic/dap.gs.267.breakpoint_action_without_debugger' into 'master'

Don't rely on Col_Num for DAP breakpoint actions

See merge request eng/ide/gnatstudio!459

Author: AdrienBoulanger

common/ui/src/dialog_utils.adb

@@ -692,6 +692,7 @@ package body Dialog_Utils is
 
       --  Insert it in the dialog view children map if a key has been specified
       if Child_Key /= "" then
+         Widget.Set_Name (Child_Key);
          Self.Parent_View.Children_Map.Insert
            (Child_Key, Gtk_Flow_Box_Child (Child_Box.Get_Parent));
       end if;

common/ui/src/dialog_utils.ads

@@ -265,7 +265,8 @@ package Dialog_Utils is
    --  associating it with an optional Child_Key.
    --
    --  If a Child_Key is specified, it will allow you to interact with this
-   --  child (see the 'Set_Child_Highlighted' subprogram).
+   --  child (see the 'Set_Child_Highlighted' subprogram). It will also be set
+   --  as the widget name.
    --
    --  The final child's layout depends on the optional parameters:
    --

dap/src/dap-clients-breakpoint_managers.adb

@@ -847,6 +847,34 @@ package body DAP.Clients.Breakpoint_Managers is
       Self.Synchonize_Breakpoints (Sync_Data);
    end Set_Breakpoints_State;
 
+   -------------------------------
+   -- Get_Breakpoint_From_Index --
+   -------------------------------
+
+   function Get_Breakpoint_From_Index
+     (Self   : not null access Breakpoint_Manager_Type;
+      Index  : Positive)
+      return DAP.Types.Breakpoints.Breakpoint_Data is
+   begin
+      return Self.Holder.Get_Breakpoint_From_Index (Index);
+   end Get_Breakpoint_From_Index;
+
+   ------------------------------
+   -- Set_Breakpoints_At_Index --
+   ------------------------------
+
+   procedure Replace_Breakpoint_At_Index
+     (Self   : not null access Breakpoint_Manager_Type;
+      Data   : DAP.Types.Breakpoints.Breakpoint_Data;
+      Index  : Positive)
+   is
+      Sync_Data : Synchonization_Data;
+   begin
+      Self.Holder.Replace (Data, Index);
+      Update_Sychronization_Data (Sync_Data, Data);
+      Self.Synchonize_Breakpoints (Sync_Data);
+   end Replace_Breakpoint_At_Index;
+
    ----------------------
    -- Set_Ignore_Count --
    ----------------------

dap/src/dap-clients-breakpoint_managers.ads

@@ -125,6 +125,18 @@ package DAP.Clients.Breakpoint_Managers is
       State   : Boolean);
    --  Enable/disable breakpoints
 
+   function Get_Breakpoint_From_Index
+     (Self   : not null access Breakpoint_Manager_Type;
+      Index  : Positive)
+      return DAP.Types.Breakpoints.Breakpoint_Data;
+   --  Retrieve data for breakpoint at Index
+
+   procedure Replace_Breakpoint_At_Index
+     (Self   : not null access Breakpoint_Manager_Type;
+      Data   : DAP.Types.Breakpoints.Breakpoint_Data;
+      Index  : Positive);
+   --  Replace data for breakpoint at Index
+
    procedure Set_Breakpoint_Command
      (Self    : not null access Breakpoint_Manager_Type;
       Id      : Breakpoint_Identifier;

dap/src/dap-module-breakpoints.adb

@@ -1108,6 +1108,40 @@ package body DAP.Module.Breakpoints is
       end if;
    end Set_Breakpoints_State;
 
+   -------------------------------
+   -- Get_Breakpoint_From_Index --
+   -------------------------------
+
+   function Get_Breakpoint_From_Index
+     (Index  : Positive) return Breakpoint_Data is
+   begin
+      if DAP.Module.Get_Current_Debugger = null then
+         return Persistent_Breakpoints.Get_Breakpoint_From_Index (Index);
+      else
+         return DAP.Module.Get_Current_Debugger.Get_Breakpoints_Manager.
+           Get_Breakpoint_From_Index (Index);
+      end if;
+   end Get_Breakpoint_From_Index;
+
+   -----------------------------
+   -- Set_Breakpoint_At_Index --
+   -----------------------------
+
+   procedure Set_Breakpoint_At_Index
+     (Kernel : not null access Kernel_Handle_Record'Class;
+      Data   : Breakpoint_Data;
+      Index  : Positive) is
+   begin
+      if DAP.Module.Get_Current_Debugger = null then
+         Persistent_Breakpoints.Replace (Data, Index);
+         GPS.Kernel.Hooks.Debugger_Breakpoints_Changed_Hook.Run
+           (Kernel, null);
+      else
+         DAP.Module.Get_Current_Debugger.Get_Breakpoints_Manager.
+           Replace_Breakpoint_At_Index (Data, Index);
+      end if;
+   end Set_Breakpoint_At_Index;
+
    -------------------------
    -- Store_As_Persistent --
    -------------------------

dap/src/dap-module-breakpoints.ads

@@ -45,6 +45,16 @@ package DAP.Module.Breakpoints is
    --  Return the breakpoint with the given ID.
    --  An empty breakpoint is returned if there is no breakpoint for this ID.
 
+   function Get_Breakpoint_From_Index
+     (Index  : Positive) return Breakpoint_Data;
+   --  Retrieve breakpoint at the given index.
+
+   procedure Set_Breakpoint_At_Index
+     (Kernel : not null access Kernel_Handle_Record'Class;
+      Data   : Breakpoint_Data;
+      Index  : Positive);
+   --  Update breakpoint at the given index.
+
    procedure Delete_Multiple_Breakpoints
      (Kernel  : not null access Kernel_Handle_Record'Class;
       Indexes : Breakpoint_Index_Lists.List);