Merge branch 'topic/rules/fix_syntax_errors' into 'master'

Fix syntax errors in LKQL codebase

Closes #579

See merge request eng/libadalang/langkit-query-language!573

Author: HugoGGuerrier

lkql_checker/share/lkql/kp/kp_t805_037.lkql

@@ -5,16 +5,20 @@
 @check(message="possible occurrence of KP T805-037")
 fun kp_t805_037(node) =
     node is TypeDecl(
-      f_discriminants: part@KnownDiscriminantPart,
-      f_type_def: r@RecordTypeDef(f_record_def: def@RecordDef)
+        f_discriminants: part@KnownDiscriminantPart,
+        f_type_def: RecordTypeDef(f_record_def: def@RecordDef)
     ) when {
-      val discs = from part select DefiningName;
-      [decl for decl in
-       from def.f_components select c@ComponentDecl
-       when c.f_component_def.f_type_expr is
-            s@SubtypeIndication(f_constraint: CompositeConstraint(
-                 p_is_discriminant_constraint(): true)
-        and [id for id in (from c.f_default_expr select Identifier)
-             if [d for d in discs if d.p_name_matches(id)]]]
+        val discs = from part select DefiningName;
+        [
+            decl for decl in from def.f_components select c@ComponentDecl
+                when c.f_component_def.f_type_expr is SubtypeIndication(
+                    f_constraint: CompositeConstraint(
+                        p_is_discriminant_constraint(): true
+                    )
+                )
+                and [
+                    id for id in (from c.f_default_expr select Identifier)
+                    if [d for d in discs if d.p_name_matches(id)]
+                ]
+        ]
     }
-

lkql_checker/share/lkql/kp/kp_va18_003.lkql

@@ -4,16 +4,20 @@
 @check(help="possible occurrence of KP VA18-003",
        message="possible occurrence of KP VA18-003 if No_Tag is passed")
 fun kp_va18_003(node) =
-    node is CallExpr(f_suffix: l@AssocList,
-                     p_referenced_decl(): decl@SubpDecl)
-    when (match decl.p_canonical_fully_qualified_name()
-          | "^ada\.tags\.descendant_tag$"              => true
-          | "^ada\.tags\.interface_ancestor_tags$"     => true
-          | "^ada\.tags\.is_descendant_at_same_level$" => true
-          | *                                          => false)
-     # check all parameters of type Tag
-     and [a for a in l.children
-          if a.f_r_expr is not
-              AttributeRef(f_attribute:
-                  Identifier(p_name_is("Tag"): true) and
-             a.f_r_expr.p_expression_type().p_relative_name().p_name_is("Tag")]
+    node is CallExpr(
+        f_suffix: l@AssocList,
+        p_referenced_decl(): decl@SubpDecl
+    ) when (
+        match decl.p_canonical_fully_qualified_name()
+        | "^ada\.tags\.descendant_tag$"              => true
+        | "^ada\.tags\.interface_ancestor_tags$"     => true
+        | "^ada\.tags\.is_descendant_at_same_level$" => true
+        | *                                          => false
+    ) and [
+        # check all parameters of type Tag
+        a
+        for a in l.children
+        if a.f_r_expr is not AttributeRef(
+            f_attribute: Identifier(p_name_is("Tag"): true)
+        ) and a.f_r_expr.p_expression_type().p_relative_name().p_name_is("Tag")
+    ]

lkql_checker/share/lkql/stdlib.lkql

@@ -552,7 +552,7 @@ fun number_of_values(type) =
     |" Return the number of values covered by a given BaseTypeDecl, -1 if
     |" this value cannot be determined.
     match type
-    | SubtypeDecl(f_subtype: *(f_constraint: RangeConstraint(f_range: *(f_range: op@BinOp)) => range_values(op.f_left, op.f_right)
+    | SubtypeDecl(f_subtype: *(f_constraint: RangeConstraint(f_range: *(f_range: op@BinOp)))) => range_values(op.f_left, op.f_right)
     | SubtypeDecl => number_of_values(type.f_subtype.f_name.p_referenced_decl())
     | * when type == type.p_universal_int_type() => -1
     | TypeDecl(f_type_def: type_def) => match type_def