Remove usage of GNAT.Command_Line to parse arguments

It's last usage was for explicit source files provided through the CLI.
Also remove the now useless 'Store' parameter from 'Store_Main_Unit' and
'Store_Sources_To_Process' procedures.

Author: HugoGGuerrier

lkql_checker/src/gnatcheck-options.adb

@@ -101,24 +101,12 @@ package body Gnatcheck.Options is
      (First_Pass : Boolean := False; Args : Argument_List_Access := null)
    is
       Unknown_Opt_Parse_Args : XString_Vector;
-      Args_After_Opt_Parse   : Argument_List_Access;
-      Parser                 : Opt_Parser;
+      Exp_It                 : Expansion_Iterator;
+      Explicit_Sources       : String_Vector;
 
-      function To_Arg_List (Args : XString_Vector) return Argument_List_Access;
       function To_XString_Array
         (Args : Argument_List_Access) return XString_Array;
 
-      function To_Arg_List (Args : XString_Vector) return Argument_List_Access
-      is
-         Ret : constant Argument_List_Access :=
-           new String_List (1 .. Args.Last_Index);
-      begin
-         for I in Ret'Range loop
-            Ret (I) := new String'(Args (I).To_String);
-         end loop;
-         return Ret;
-      end To_Arg_List;
-
       function To_XString_Array
         (Args : Argument_List_Access) return XString_Array
       is
@@ -138,8 +126,6 @@ package body Gnatcheck.Options is
         Compose (Compose (Prefix, "share"), "lkql");
 
       Args_From_Project : constant Boolean := Args /= null;
-      Initial_Char      : Character;
-      Success           : Boolean;
 
       --  Start of processing for Scan_Arguments
 
@@ -183,14 +169,12 @@ package body Gnatcheck.Options is
          end;
       end if;
 
-      if Arg.Parser.Parse
-           ((if Args /= null then To_XString_Array (Args) else No_Arguments),
-            Unknown_Arguments => Unknown_Opt_Parse_Args)
+      if not Arg.Parser.Parse
+               ((if Args /= null
+                 then To_XString_Array (Args)
+                 else No_Arguments),
+                Unknown_Arguments => Unknown_Opt_Parse_Args)
       then
-         Args_After_Opt_Parse := To_Arg_List (Unknown_Opt_Parse_Args);
-         Initialize_Option_Scan
-           (Parser, Args_After_Opt_Parse, Section_Delimiters => "cargs rules");
-      else
          raise Parameter_Error;
       end if;
 
@@ -213,54 +197,56 @@ package body Gnatcheck.Options is
          Allow (Arg.List_Rules.This);
       end if;
 
-      loop
-         Initial_Char := Getopt (" ", Parser => Parser);
-
-         case Initial_Char is
-            when ASCII.NUL =>
-               Success := False;
-
-               loop
-                  declare
-                     Arg : constant String :=
-                       Get_Argument (Do_Expansion => True, Parser => Parser);
-
-                  begin
-                     exit when Arg = "";
-                     Success := True;
-
-                     if Options.Arg.Transitive_Closure.Get then
-                        Store_Main_Unit (Arg, Args_From_Project or First_Pass);
-                     else
-                        Store_Sources_To_Process
-                          (Arg, Args_From_Project or First_Pass);
-
-                        if not Args_From_Project then
-                           Argument_File_Specified := True;
-                        end if;
-                     end if;
-                  end;
-               end loop;
-
-               exit when not Success;
-
-            when others    =>
-               Error
-                 ("unrecognized switch: " & Full_Switch (Parser => Parser));
-               raise Parameter_Error;
-         end case;
+      --  Now that we processed all switches, remaining arguments should be
+      --  source files to analyze.
+      --  We first have to check that there is no additional argument and
+      --  expand possible glob patterns.
+      for Unknown_Arg of Unknown_Opt_Parse_Args loop
+         --  We consider that arguments starting by "-" are remaining unknown
+         --  arguments.
+         if Unknown_Arg.Starts_With ("-") then
+            Error ("unrecognized switch: " & To_String (Unknown_Arg));
+            raise Parameter_Error;
+
+         --  We now know that the current argument should be handled like an
+         --  Ada source file name OR a glob pattern.
+         --  We only handle explicit sources during the first pass to avoid
+         --  duplication.
+         elsif Args_From_Project or First_Pass then
+            declare
+               Is_Glob : constant Boolean :=
+                 Unknown_Arg.Find ('*') /= 0
+                 or else Unknown_Arg.Find ('?') /= 0
+                 or else Unknown_Arg.Find ('[') /= 0;
+            begin
+               if Is_Glob then
+                  Start_Expansion (Exp_It, To_String (Unknown_Arg));
+                  loop
+                     declare
+                        Expanded_Arg : constant String := Expansion (Exp_It);
+                     begin
+                        exit when Expanded_Arg = "";
+                        Explicit_Sources.Append (Expanded_Arg);
+                     end;
+                  end loop;
+               else
+                  Explicit_Sources.Append (To_String (Unknown_Arg));
+               end if;
+            end;
+         end if;
       end loop;
 
-   exception
-      when Invalid_Switch =>
-         Error ("invalid switch: " & Full_Switch (Parser => Parser));
-         raise Parameter_Error;
-
-      when Invalid_Parameter =>
-         Error
-           ("missing Parameter (Parser => Parser) for: -"
-            & Full_Switch (Parser => Parser));
-         raise Parameter_Error;
+      --  We can now store sources to process
+      for Arg of Explicit_Sources loop
+         if Options.Arg.Transitive_Closure.Get then
+            Store_Main_Unit (Arg);
+         else
+            Store_Sources_To_Process (Arg);
+            if not Args_From_Project then
+               Argument_File_Specified := True;
+            end if;
+         end if;
+      end loop;
    end Scan_Arguments;
 
    ---------------------------------

lkql_checker/src/gnatcheck-projects.adb

@@ -892,11 +892,9 @@ package body Gnatcheck.Projects is
    -- Store_Main_Unit --
    ---------------------
 
-   procedure Store_Main_Unit (Unit_Name : String; Store : Boolean := True) is
+   procedure Store_Main_Unit (Unit_Name : String) is
    begin
-      if Store then
-         Gnatcheck.Projects.Main_Unit.Include (GPR2.Filename_Type (Unit_Name));
-      end if;
+      Gnatcheck.Projects.Main_Unit.Include (GPR2.Filename_Type (Unit_Name));
    end Store_Main_Unit;
 
    --------------------------

lkql_checker/src/gnatcheck-projects.ads

@@ -112,13 +112,9 @@ package Gnatcheck.Projects is
    --  If the tool is called with "... Pproj -U main_unit1 main_unit2 ...",
    --  main units are stored here.
 
-   procedure Store_Main_Unit (Unit_Name : String; Store : Boolean := True);
-   --  Processes the result returned by GNAT.Comand_Line.Get_Argument provided
-   --  that it is supposed to be the main unit name for '-U' project file
+   procedure Store_Main_Unit (Unit_Name : String);
+   --  Processes the provided name as the main unit name for '-U' project file
    --  option.
-   --
-   --  If Store is ON, stores the name of the unit. If Store is OFF,
-   --  does not store anything.
 
    -----------------------------------------------------------
    --  -Xvariable=value  : set values of external variables --

lkql_checker/src/gnatcheck-source_table.ads

@@ -95,8 +95,6 @@ package Gnatcheck.Source_Table is
    --  Fname is stored in an internal database as the name of the file to be
    --  processed by the tool. No check is made if Fname denotes an existing
    --  file.
-   --
-   --  If Store is False then the procedure does not store anything.
 
    procedure Read_Args_From_Temp_Storage
      (Duplication_Report : Boolean;