Merge branch 'topic/509' into 'master'

Do not rely on Full_Name when processing rule files

Closes #509

See merge request eng/libadalang/langkit-query-language!492

Author: thvnx

lkql_checker/src/rules_factory.adb

@@ -3,6 +3,7 @@
 --  SPDX-License-Identifier: GPL-3.0-or-later
 --
 
+with Ada.Containers.Ordered_Sets;
 with Ada.Environment_Variables;
 
 with GNAT.OS_Lib;
@@ -35,9 +36,12 @@ package body Rules_Factory is
      (Ctx : L.Analysis_Context; Dirs : Path_Array := No_Paths)
       return Rule_Vector
    is
+      package Virtual_File_Sets is new
+        Ada.Containers.Ordered_Sets (Element_Type => Virtual_File);
+
       Rules_Dirs : constant Virtual_File_Array := Get_Rules_Directories (Dirs);
       Rules      : Rule_Vector := Rule_Vectors.Empty_Vector;
-      Seen       : String_Sets.Set := String_Sets.Empty_Set;
+      Seen       : Virtual_File_Sets.Set := Virtual_File_Sets.Empty_Set;
       Impacts    : constant JSON_Value := Get_Impacts (Rules_Dirs);
 
    begin
@@ -53,7 +57,7 @@ package body Rules_Factory is
             begin
                for File of Dir.all loop
                   if File.File_Extension = +".lkql"
-                    and then not Seen.Contains (+File.Full_Name)
+                    and then not Seen.Contains (File)
                   then
                      declare
                         Rc : Rule_Command;
@@ -64,7 +68,7 @@ package body Rules_Factory is
                      begin
                         if Has_Rule then
                            Rules.Append (Rc);
-                           Seen.Include (+File.Full_Name);
+                           Seen.Include (File);
                         end if;
                      end;
                   end if;

testsuite/tests/gnatcheck/rules_dir/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/gnatcheck/rules_dir/rules/my_rule.lkql

@@ -0,0 +1,3 @@
+@check(help="help", message="message")
+fun my_rule(node) =
+    node is DefiningName

testsuite/tests/gnatcheck/rules_dir/test.adb

@@ -0,0 +1,4 @@
+procedure Test is -- FLAG
+begin
+   null;
+end;

testsuite/tests/gnatcheck/rules_dir/test.out

@@ -0,0 +1,35 @@
+1. Summary
+
+   fully compliant sources               : 0
+   sources with exempted violations only : 0
+   sources with non-exempted violations  : 1
+   unverified sources                    : 0
+   total sources                         : 1
+   ignored sources                       : 0
+
+   non-exempted violations               : 1
+   rule exemption warnings               : 0
+   compilation errors                    : 0
+   exempted violations                   : 0
+   internal errors                       : 0
+
+2. Exempted Coding Standard Violations
+
+   no exempted violations detected
+
+3. Non-exempted Coding Standard Violations
+
+test.adb:1:11: rule violation: message
+
+4. Rule exemption problems
+
+   no rule exemption problems detected
+
+5. Language violations
+
+   no language violations detected
+
+6. Gnatcheck internal errors
+
+   no internal error detected
+

testsuite/tests/gnatcheck/rules_dir/test.yaml

@@ -0,0 +1,10 @@
+description: |
+  Ensure GNATCheck can handle several times the same rule directory and properly
+  builds a set of unique rules.
+driver: gnatcheck
+project: prj.gpr
+rules_dirs:
+  - rules
+  - ./rules/../rules
+rules:
+  - +Rmy_rule