Perf: Reoptimize method call targets

They were not optimized anymore due to the wrapper method object being
different every time

Author: raph-amiard

lkql_jit/language/src/main/java/com/adacore/lkql_jit/built_ins/BuiltInFunctionValue.java

@@ -41,6 +41,23 @@ public BuiltInFunctionValue(
         stringDefaultVals = defaultValues;
     }
 
+    public BuiltInFunctionValue(
+        String documentation,
+        String[] names,
+        String[] defaultValues,
+        FunctionRootNode functionRootNode
+    ) {
+        super(
+            functionRootNode,
+            Closure.EMPTY,
+            functionRootNode.getName(),
+            documentation,
+            names,
+            new Expr[names.length]
+        );
+        stringDefaultVals = defaultValues;
+    }
+
     @Override
     public Expr[] getParameterDefaultValues() {
         if (stringDefaultVals != null && !defaultValsEvald) {

lkql_jit/language/src/main/java/com/adacore/lkql_jit/built_ins/BuiltInMethodFactory.java

@@ -5,6 +5,7 @@
 
 package com.adacore.lkql_jit.built_ins;
 
+import com.adacore.lkql_jit.nodes.root_nodes.FunctionRootNode;
 import com.adacore.lkql_jit.utils.functions.ArrayUtils;
 
 /**
@@ -21,6 +22,8 @@ public final class BuiltInMethodFactory {
 
     public final String[] paramNames;
 
+    private final FunctionRootNode functionRootNode;
+
     public String[] defaultValues;
 
     public final BuiltInBody methodBody;
@@ -48,20 +51,20 @@ public BuiltInMethodFactory(
         this.defaultValues = defaultValues;
         this.methodBody = methodBody;
         this.isProperty = isProperty;
+        this.functionRootNode = new FunctionRootNode(null, null, false, methodBody, name);
     }
 
     // ----- Instance methods -----
 
     /** Instantiate the method with the given "thisValue" and return the LKQL value. */
     public BuiltInMethodValue instantiate(Object thisValue) {
         return this.isProperty
-            ? new BuiltInPropertyValue(this.name, this.documentation, this.methodBody, thisValue)
+            ? new BuiltInPropertyValue(documentation, functionRootNode, thisValue)
             : new BuiltInMethodValue(
-                this.name,
-                this.documentation,
-                this.paramNames,
-                this.defaultValues,
-                this.methodBody,
+                documentation,
+                paramNames,
+                defaultValues,
+                functionRootNode,
                 thisValue
             );
     }

lkql_jit/language/src/main/java/com/adacore/lkql_jit/built_ins/BuiltInMethodValue.java

@@ -5,6 +5,8 @@
 
 package com.adacore.lkql_jit.built_ins;
 
+import com.adacore.lkql_jit.nodes.root_nodes.FunctionRootNode;
+
 /** This class represents the LKQL value of an instantiated built-in method. */
 public class BuiltInMethodValue extends BuiltInFunctionValue {
 
@@ -20,14 +22,13 @@ public class BuiltInMethodValue extends BuiltInFunctionValue {
      * "this" value.
      */
     public BuiltInMethodValue(
-        String name,
         String documentation,
         String[] names,
         String[] defaultValues,
-        BuiltInBody body,
+        FunctionRootNode functionRootNode,
         Object thisValue
     ) {
-        super(name, documentation, names, defaultValues, body);
+        super(documentation, names, defaultValues, functionRootNode);
         this.thisValue = thisValue;
     }
 }

lkql_jit/language/src/main/java/com/adacore/lkql_jit/built_ins/BuiltInPropertyValue.java

@@ -5,6 +5,8 @@
 
 package com.adacore.lkql_jit.built_ins;
 
+import com.adacore.lkql_jit.nodes.root_nodes.FunctionRootNode;
+
 /**
  * This class represents the LKQL value of an instantiated attribute. An attribute is a special
  * method with not other arguments than "this" and is called implicitly by the dotted-name notation.
@@ -13,11 +15,16 @@ public class BuiltInPropertyValue extends BuiltInMethodValue {
 
     /** Create a new built-in attribute value. */
     public BuiltInPropertyValue(
-        String name,
         String documentation,
-        BuiltInBody body,
+        FunctionRootNode functionRootNode,
         Object thisValue
     ) {
-        super(name, documentation, new String[] { "this" }, new String[] { null }, body, thisValue);
+        super(
+            documentation,
+            new String[] { "this" },
+            new String[] { null },
+            functionRootNode,
+            thisValue
+        );
     }
 }

lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/expressions/dot/DotAccess.java

@@ -79,10 +79,6 @@ protected Object onNamespace(
 
     /**
      * Execute the dot access on a node with the cached strategy.
-     *
-     * @param property The cached property reference.
-     * @param isField The cached value if the property is a field.
-     * @return The property reference or the field value.
      */
     @Specialization(
         guards = {
@@ -110,8 +106,6 @@ protected Object onNodeCached(
 
     /**
      * Execute the dot access on a node with the un-cached strategy.
-     *
-     * @return The property call or the file value.
      */
     @Specialization(replaces = "onNodeCached")
     protected Object onNodeUncached(LangkitSupport.NodeInterface receiver) {

lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/expressions/dot/DotAccessWrapper.java

@@ -6,17 +6,14 @@
 package com.adacore.lkql_jit.nodes.expressions.dot;
 
 import com.adacore.lkql_jit.built_ins.BuiltInPropertyValue;
-import com.adacore.lkql_jit.exception.LKQLRuntimeException;
 import com.adacore.lkql_jit.nodes.expressions.Expr;
 import com.adacore.lkql_jit.utils.Constants;
+import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.api.interop.ArityException;
-import com.oracle.truffle.api.interop.InteropLibrary;
-import com.oracle.truffle.api.interop.UnsupportedMessageException;
-import com.oracle.truffle.api.interop.UnsupportedTypeException;
-import com.oracle.truffle.api.library.CachedLibrary;
+import com.oracle.truffle.api.nodes.DirectCallNode;
+import com.oracle.truffle.api.nodes.IndirectCallNode;
 import com.oracle.truffle.api.source.SourceSection;
 
 /**
@@ -40,16 +37,23 @@ public DotAccessWrapper(SourceSection location) {
      * When the child dot-access is returning an attribute, execute this attribute implicitly and
      * return the result of this execution.
      */
-    @Specialization(limit = Constants.SPECIALIZED_LIB_LIMIT)
-    protected Object onAttribute(
+    @Specialization(
+        limit = Constants.SPECIALIZED_LIB_LIMIT,
+        guards = "attribute.getCallTarget() == directCallNode.getCallTarget()"
+    )
+    protected Object doCached(
         BuiltInPropertyValue attribute,
-        @CachedLibrary("attribute") InteropLibrary attributeLibrary
+        @Cached("create(attribute.getCallTarget())") DirectCallNode directCallNode
     ) {
-        try {
-            return attributeLibrary.execute(attribute, attribute.thisValue);
-        } catch (ArityException | UnsupportedTypeException | UnsupportedMessageException e) {
-            throw LKQLRuntimeException.fromJavaException(e, this);
-        }
+        return directCallNode.call(attribute.thisValue);
+    }
+
+    @Specialization(replaces = "doCached")
+    protected Object doUncached(
+        BuiltInPropertyValue attribute,
+        @Cached IndirectCallNode indirectCallNode
+    ) {
+        return indirectCallNode.call(attribute.getCallTarget(), attribute.thisValue);
     }
 
     /** For other cases, just return the dot access result value. */

lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/root_nodes/SelectorRootNode.java

@@ -86,6 +86,7 @@ public Object execute(VirtualFrame frame) {
         LKQLRecValue res;
 
         var val = body.executeGeneric(frame);
+
         if (LKQLTypeSystemGen.isLKQLRecValue(val)) {
             res = LKQLTypeSystemGen.asLKQLRecValue(val);
             res.depth = (int) depth + 1;