Merge branch 'topic/84' into 'master'

Fetch gnat-kp impact data from impact-db

See merge request eng/libadalang/langkit-query-language!337

Author: thvnx

Makefile

@@ -13,6 +13,7 @@ PYTHON=python
 MAVEN=mvn
 BUILD_DIR=/undefined
 LKQL_DIR=$(BUILD_DIR)/lkql
+IMPACTDB_DIR=/undefined
 GPRBUILD=gprbuild -j$(PROCS) -p -XBUILD_MODE=$(BUILD_MODE)
 GPRINSTALL=gprinstall --prefix=$(PREFIX) -p -XBUILD_MODE=$(BUILD_MODE)
 BUILD_FOR_JIT=false
@@ -36,6 +37,9 @@ doc: build_lkql_native_jit
 	cd user_manual && make clean html
 	cd lkql_checker/doc && make generate html-all
 
+impacts:
+	PYTHONPATH=$(IMPACTDB_DIR) ./utils/impact-db_impacts_gen.py $(IMPACTDB_DIR)
+
 format:
 	$(MAVEN) -f lkql_jit spotless:apply
 

lkql_checker/share/lkql/kp/KP-18614.lkql

@@ -4,7 +4,7 @@ fun multiple_of(v, multiple) = v / multiple * multiple == v
 
 @check(help="possible occurrence of KP 18614",
        message="possible occurrence of KP 18614 if compiled with optimization",
-       impact="2[0-3].*", target="powerpc*,leon*,sparc*")
+       target="powerpc*,leon*,sparc*")
 fun kp_18614(node) =
     node is Aggregate(p_expression_type():
         t@BaseTypeDecl(p_is_array_type(): true)

lkql_checker/share/lkql/kp/KP-18636.lkql

@@ -1,6 +1,6 @@
 # Flag 'Image applied to objects of a class-wide interface type
 
-@check(message="possible occurrence of KP 18636", impact="22.*,23.*")
+@check(message="possible occurrence of KP 18636")
 fun kp_18636(node) =
     node is AttributeRef
     when node.f_attribute.p_name_is("Image")

lkql_checker/share/lkql/kp/KP-18637.lkql

@@ -3,7 +3,7 @@
 
 import stdlib
 
-@check(message="possible occurrence of KP 18637", impact="23.*")
+@check(message="possible occurrence of KP 18637")
 fun kp_18637(node) =
     node is CallExpr(
         f_name: Name(

lkql_checker/share/lkql/kp/KP-18701.lkql

@@ -3,7 +3,7 @@
 
 import stdlib
 
-@check(message="possible occurrence of KP 18701", impact="23.*")
+@check(message="possible occurrence of KP 18701")
 fun kp_18701(node) =
     node is Aggregate
     when node.p_expression_type() is BaseTypeDecl(

lkql_checker/share/lkql/kp/KP-18718.lkql

@@ -4,8 +4,7 @@
 # variant part
 
 @check(help="possible occurrence of KP 18718",
-       message="possible occurrence of KP 18718 if compiled with optimization",
-       impact="23.*")
+       message="possible occurrence of KP 18718 if compiled with optimization")
 fun kp_18718(node) =
     node is ObjectDecl(
         # An ObjectDecl with a default expression being a function call

lkql_checker/share/lkql/kp/KP-18801.lkql

@@ -45,8 +45,7 @@ fun check_params(n) = {
 }
 
 @check(help="possible occurrence of KP 18801",
-       message="possible occurrence of KP 18801",
-       impact="23.*")
+       message="possible occurrence of KP 18801")
 fun kp_18801(node) =
     node is (BinOp(f_op: OpEq) |
              CallExpr(p_kind(): "call") when node.f_name.p_name_is("\"=\""))

lkql_checker/share/lkql/kp/KP-18926.lkql

@@ -20,8 +20,7 @@ fun is_flagged_aspect(aspect) =
     | * => false
 
 @check(help="possible occurrence of KP 18926",
-       message="possible occurrence of KP 18926",
-       impact="23.*,24.1")
+       message="possible occurrence of KP 18926")
 fun kp_18926(node) =
     node is BracketAggregate
     when is_flagged_aspect(node.p_expression_type().p_get_aspect("Aggregate"))

lkql_checker/share/lkql/kp/KP-19038.lkql

@@ -1,6 +1,5 @@
 @check(help="possible occurrence of KP 19038",
-       message="possible occurrence of KP 19038",
-       impact="24.1")
+       message="possible occurrence of KP 19038")
 fun kp_19038(node) =
     |" Detect all occurrences of aspect "Exclusive_Functions".
     node is AspectAssoc(

lkql_checker/share/lkql/kp/KP-19134.lkql

@@ -26,8 +26,7 @@ fun is_unck_conv_to_array_of_int(call) =
     }
 
 @check(help="possible occurrence of KP 19134",
-       message="possible occurrence of KP 19134",
-       impact="23.*,24.*")
+       message="possible occurrence of KP 19134")
 fun kp_19134(node) =
     node is CallExpr(p_is_call(): true)
     when stdlib.any([is_unck_conv_to_array_of_int(p.actual)