Fix emission of the '-rules' depreciation message

Avoid multiple emission of this message and categories it as an information
message, not an error.

Author: HugoGGuerrier

lkql_checker/src/gnatcheck-output.adb

@@ -123,17 +123,6 @@ package body Gnatcheck.Output is
       end if;
    end Error_No_Tool_Name;
 
-   ------------------
-   -- Error_In_Tty --
-   ------------------
-
-   procedure Error_In_Tty (Message : String) is
-   begin
-      if isatty (fileno (stderr)) /= 0 then
-         Put_Line (Standard_Error, Executable & ": " & Message);
-      end if;
-   end Error_In_Tty;
-
    -----------------------
    -- Get_Indent_String --
    -----------------------
@@ -314,6 +303,17 @@ package body Gnatcheck.Output is
       end if;
    end Info_No_EOL;
 
+   -----------------
+   -- Info_In_Tty --
+   -----------------
+
+   procedure Info_In_Tty (Message : String) is
+   begin
+      if isatty (fileno (stderr)) /= 0 then
+         Put_Line (Standard_Error, Message);
+      end if;
+   end Info_In_Tty;
+
    ------------------------
    -- Print_Tool_Version --
    ------------------------

lkql_checker/src/gnatcheck-output.ads

@@ -43,10 +43,6 @@ package Gnatcheck.Output is
    procedure Error_No_Tool_Name (Message : String);
    --  Sends into Stderr the error message with no tool name prefix
 
-   procedure Error_In_Tty (Message : String);
-   --  Same as ``Error`` but send the message only if Stderr is a TTY. Also,
-   --  ``Message`` is not added to the stderr log file.
-
    procedure Warning (Message : String);
    --  Same as Error, but do nothing if Warning_Mode = Quiet.
 
@@ -71,6 +67,10 @@ package Gnatcheck.Output is
    --  that is, the last line does not contain a (platform-specific) EOL
    --  character(s).
 
+   procedure Info_In_Tty (Message : String);
+   --  Same as ``Info`` but send the message only if Stderr is a TTY. Also,
+   --  ``Message`` is not added to the current ``Log_File``.
+
    Indent_String : constant String := "   ";
    --  Used as indentation element in various output
 

lkql_checker/src/gnatcheck-projects.adb

@@ -1212,13 +1212,14 @@ package body Gnatcheck.Projects is
                   Individual_Rules_Set := True;
             end case;
             if not Rules_Depreciation_Emitted then
-               Error_In_Tty
+               Info_In_Tty
                  ("The '-rules' section is now deprecated. You should only " &
                   "use the '--rule' and '--rule-file' command-line options.");
-               Error_In_Tty
+               Info_In_Tty
                  ("You can use the '--emit-lkql-rule-file' flag to " &
                   "automatically translate your rule configuration to the " &
                   "new LKQL format.");
+               Rules_Depreciation_Emitted := True;
             end if;
          end loop;
       end Process_Sections;

testsuite/tests/gnatcheck/rules_depreciation_message/test.out

@@ -1,3 +1,3 @@
-gnatcheck: The '-rules' section is now deprecated. You should only use the '--rule' and '--rule-file' command-line options.
-gnatcheck: You can use the '--emit-lkql-rule-file' flag to automatically translate your rule configuration to the new LKQL format.
+The '-rules' section is now deprecated. You should only use the '--rule' and '--rule-file' command-line options.
+You can use the '--emit-lkql-rule-file' flag to automatically translate your rule configuration to the new LKQL format.
 main.adb:3:04: goto statement