Merge branch 'topic/gnatcheck/migrate_gnatcheck_tests' into 'master'

Cleanup and add features to the GNATcheck testing driver

See merge request eng/libadalang/langkit-query-language!554

Author: HugoGGuerrier

testsuite/drivers/base_driver.py

@@ -146,7 +146,7 @@ def add_missing_flags(self):
         # For each line where an annotation is missing, add it before any other comment
         for line, count in missing_flag_annotations.items():
             # Split the source line to get the code and the comment parts
-            line_split = source_lines[line - 1].split("--")
+            line_split = source_lines[line - 1].split("--", maxsplit=1)
             code, comment = line_split[0], line_split[1].strip() if len(line_split) == 2 else ""
 
             # Remove the already existing FLAG annotation if there is one

testsuite/drivers/gnatcheck_driver.py

@@ -1,7 +1,7 @@
 testsuite_driver: No output file generated by gnatcheck
 gnatcheck: error: no existing file to process
 >>>program returned status code 3
-testsuite_driver: Content of rules.lkql
+Running "cat rules.lkql"...
     goto_statements: [{}, {instance_name: "my_instance", only_unconditional: true}],
     headers: [{header: "header.txt"}],
     identifier_casing: [{exclude: "exclude.txt"}],

testsuite/tests/gnatcheck/emit_lkql_rule_file/test.out

@@ -13,4 +13,5 @@ rules:
   - +RRestrictions:No_Abort_Statements,No_Use_Of_Attribute=>Image,No_Use_Of_Entity=>Ada.Text_IO.Put_Line
 extra_args:
   - --emit-lkql-rule-file
-post_python: "cat('rules.lkql', sort=True, trim_start=1, trim_end=1)"
+post_python: cat("rules.lkql", sort=True, trim_start=1, trim_end=1)
+canonicalize_backslashes: False

testsuite/tests/gnatcheck/emit_lkql_rule_file/test.yaml

@@ -9,4 +9,8 @@ main.adb:3:05: rule violation: goto statement
 main.adb:6:05: error: "Put_Line" is undefined
 main.adb:6:05: error: possible missing "with Ada.Text_IO; use Ada.Text_IO"
    no internal error detected
-Content of custom_subdirs/gnatcheck : ['gnatcheck-log1.TMP', 'main.adb.stderr', 'main.adb.stdout', 'restriction_pragmas.adc']
+Running "ls custom_subdirs/gnatcheck"...
+gnatcheck-log1.TMP
+main.adb.stderr
+main.adb.stdout
+restriction_pragmas.adc

testsuite/tests/gnatcheck/subdirs/test.out

@@ -5,5 +5,4 @@ project: prj.gpr
 rules:
   - +RGOTO_Statements
   - +RWarnings:a
-list_dirs:
-  - custom_subdirs/gnatcheck
+post_python: ls("custom_subdirs/gnatcheck")

testsuite/tests/gnatcheck/subdirs/test.yaml

@@ -2,7 +2,7 @@ testsuite_driver: No output file generated by gnatcheck
 gnatcheck: error: no existing file to process
 gnatcheck: error: cannot emit the LKQL rule file, <working-dir>/rules.lkql already exists
 >>>program returned status code 2
-testsuite_driver: Content of rules.lkql
+Running "cat rules.lkql"...
 val rules = @{
     redundant_null_statements
 }

testsuite/tests/gnatcheck_errors/already_existing_lkql_rule_file/test.out

@@ -4,4 +4,4 @@ rules:
   - +RGoto_Statements
 extra_args:
   - --emit-lkql-rule-file
-post_python: "cat('rules.lkql', sort=False)"
+post_python: cat("rules.lkql", sort=False)