Merge branch 'topic/kp_19753' into 'master'

Add detector for KP-19753

Closes #440

See merge request eng/libadalang/langkit-query-language!405

Author: HugoGGuerrier

lkql_checker/share/lkql/kp/KP-19753.lkql

@@ -0,0 +1,6 @@
+@check(help="possible occurrence of KP 19753",
+       message="possible occurrence of KP 19753")
+fun kp_19753(node) =
+    |" Flag loop body which have a raise statement as first non-null statement.
+    node is BaseLoopStmt
+    when [n for n in node.f_stmts.children if n is not NullStmt]?[1] is RaiseStmt

lkql_checker/share/lkql/kp/kp.json

@@ -22,6 +22,7 @@
         "kp_19529": "24.*",
         "kp_19625": "24.*",
         "kp_19696": "24.*,25.1",
+        "kp_19753": "21.*,22.*,23.*,24.*,25.*",
         "kp_ob03_009": "19.*",
         "kp_p226_024": "7.1.*,7.2.*,7.3.*,7.4.1,7.4.2,7.4.3",
         "kp_q309_014": "7.1.*,7.2.*,7.3.*,7.4.*,17.*",

testsuite/tests/checks/KP-19753/main.adb

@@ -0,0 +1,35 @@
+procedure Main is
+   A : array (1 .. 5) of Integer;
+begin
+   for I in 1 .. 5 loop          --  FLAG
+      raise Constraint_Error;
+   end loop;
+
+   for I of A loop               --  FLAG
+      raise Constraint_Error;
+   end loop;
+
+   loop                          --  FLAG
+      raise Constraint_Error;
+   end loop;
+
+   loop                          --  FLAG
+      null;
+      null;
+      null;
+      raise Constraint_Error;
+   end loop;
+
+   loop                          --  FLAG
+      null;
+      null;
+      null;
+      raise Constraint_Error;
+      A (1) := 0;
+   end loop;
+
+   loop                          --  NOFLAG
+      A (1) := 0;
+      raise Constraint_Error;
+   end loop;
+end Main;

testsuite/tests/checks/KP-19753/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/KP-19753/test.out

@@ -0,0 +1,45 @@
+main.adb:4:4: rule violation: possible occurrence of KP 19753
+4 |     for I in 1 .. 5 loop          --  FLAG
+  | ____^
+  ||
+  || ~~~ 1 other lines ~~~
+  ||
+6 ||    end loop;
+  ||____________^
+
+main.adb:8:4: rule violation: possible occurrence of KP 19753
+8  |     for I of A loop               --  FLAG
+   | ____^
+   ||
+   || ~~~ 1 other lines ~~~
+   ||
+10 ||    end loop;
+   ||____________^
+
+main.adb:12:4: rule violation: possible occurrence of KP 19753
+12 |     loop                          --  FLAG
+   | ____^
+   ||
+   || ~~~ 1 other lines ~~~
+   ||
+14 ||    end loop;
+   ||____________^
+
+main.adb:16:4: rule violation: possible occurrence of KP 19753
+16 |     loop                          --  FLAG
+   | ____^
+   ||
+   || ~~~ 4 other lines ~~~
+   ||
+21 ||    end loop;
+   ||____________^
+
+main.adb:23:4: rule violation: possible occurrence of KP 19753
+23 |     loop                          --  FLAG
+   | ____^
+   ||
+   || ~~~ 5 other lines ~~~
+   ||
+29 ||    end loop;
+   ||____________^
+

testsuite/tests/checks/KP-19753/test.yaml

@@ -0,0 +1,3 @@
+driver: checker
+rule_name: kp_19753
+project: prj.gpr

testsuite/tests/gnatcheck/xml_help/test.out

@@ -88,6 +88,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_19529" label="possible occurrence of KP 19529"/>
       <check switch="+Rkp_19625" label="possible occurrence of KP 19625"/>
       <check switch="+Rkp_19696" label="possible occurrence of KP 19696"/>
+      <check switch="+Rkp_19753" label="possible occurrence of KP 19753"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>
@@ -598,6 +599,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_19529" label="possible occurrence of KP 19529"/>
       <check switch="+Rkp_19625" label="possible occurrence of KP 19625"/>
       <check switch="+Rkp_19696" label="possible occurrence of KP 19696"/>
+      <check switch="+Rkp_19753" label="possible occurrence of KP 19753"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>