Merge branch 'topic/453' into 'master'

Fix use_memberships rule to avoid calling properties with null nodes

Closes #453

See merge request eng/libadalang/langkit-query-language!419

Author: thvnx

lkql_checker/share/lkql/use_memberships.lkql

@@ -120,4 +120,6 @@ fun use_memberships(node, short_circuit = false) =
     ) when stdlib.is_predefined_op(op)
 
     # Find a first variable used as LHS (id) and pass it to check_expr
-    and check_expr(node, get_first_id(node), short_circuit)
+    and if not get_first_id(node) is null
+        then check_expr(node, get_first_id(node), short_circuit)
+        else false

testsuite/tests/checks/use_memberships/member.adb

@@ -1,6 +1,9 @@
 procedure Member (A, B : Integer) is
    Bool : Boolean;
    subtype S is Integer range 1 .. B;
+   type E is (X, Y, Z);
+
+   function Func (A, B, C : Integer) return E is (X);
 begin
    if A = 0            --  FLAG
      or A in Natural
@@ -40,4 +43,9 @@ begin
    Bool := A >= 1 and A <= B;             --  FLAG
    Bool := A = 100 or A in S;             --  FLAG
    Bool := A = 100 or A in 1 .. B;        --  FLAG
+
+   if Func (1, 2, 3) in X or  -- NOFLAG
+      Func (3, 4, 5) in Y then
+      null;
+   end if;
 end Member;

testsuite/tests/checks/use_memberships/test.out

@@ -1,32 +1,32 @@
-member.adb:5:7: rule violation: expression may be replaced by a membership test
-5 |     if A = 0            --  FLAG
-  | _______^
-  ||
-  || ~~~ 2 other lines ~~~
-  ||
-8 ||      or (A >= 3 and A <= 5)
-  ||___________________________^
+member.adb:8:7: rule violation: expression may be replaced by a membership test
+8  |     if A = 0            --  FLAG
+   | _______^
+   ||
+   || ~~~ 2 other lines ~~~
+   ||
+11 ||      or (A >= 3 and A <= 5)
+   ||___________________________^
 
-member.adb:13:7: rule violation: expression may be replaced by a membership test
-13 |     if A = 0            --  FLAG if short_circuit
+member.adb:16:7: rule violation: expression may be replaced by a membership test
+16 |     if A = 0            --  FLAG if short_circuit
    | _______^
-14 ||      or else (A >= 3 and A <= 5)
+17 ||      or else (A >= 3 and A <= 5)
    ||________________________________^
 
-member.adb:39:12: rule violation: expression may be replaced by a membership test
-39 |    Bool := A = B or (A >= 1 and A <= B);  --  FLAG
+member.adb:42:12: rule violation: expression may be replaced by a membership test
+42 |    Bool := A = B or (A >= 1 and A <= B);  --  FLAG
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-member.adb:40:12: rule violation: expression may be replaced by a membership test
-40 |    Bool := A >= 1 and A <= B;             --  FLAG
+member.adb:43:12: rule violation: expression may be replaced by a membership test
+43 |    Bool := A >= 1 and A <= B;             --  FLAG
    |            ^^^^^^^^^^^^^^^^^
 
-member.adb:41:12: rule violation: expression may be replaced by a membership test
-41 |    Bool := A = 100 or A in S;             --  FLAG
+member.adb:44:12: rule violation: expression may be replaced by a membership test
+44 |    Bool := A = 100 or A in S;             --  FLAG
    |            ^^^^^^^^^^^^^^^^^
 
-member.adb:42:12: rule violation: expression may be replaced by a membership test
-42 |    Bool := A = 100 or A in 1 .. B;        --  FLAG
+member.adb:45:12: rule violation: expression may be replaced by a membership test
+45 |    Bool := A = 100 or A in 1 .. B;        --  FLAG
    |            ^^^^^^^^^^^^^^^^^^^^^^
 
 Patched "member.adb":
@@ -35,6 +35,9 @@ Patched "member.adb":
 procedure Member (A, B : Integer) is
    Bool : Boolean;
    subtype S is Integer range 1 .. B;
+   type E is (X, Y, Z);
+
+   function Func (A, B, C : Integer) return E is (X);
 begin
    if A in 0            --  FLAG
      |Natural
@@ -72,5 +75,10 @@ begin
    Bool := A in 1 ..B;             --  FLAG
    Bool := A in 100 |S;             --  FLAG
    Bool := A in 100 |1 .. B;        --  FLAG
+
+   if Func (1, 2, 3) in X or  -- NOFLAG
+      Func (3, 4, 5) in Y then
+      null;
+   end if;
 end Member;