Merge branch 'topic/491' into 'master'

thvnx · thvnx · commit 84d6972f0570 · 2025-05-12T09:26:33.000Z
Fix implicit_small_for_fixed_point_types rule

Closes #491

See merge request eng/libadalang/langkit-query-language!455
diff --git a/lkql_checker/share/lkql/implicit_small_for_fixed_point_types.lkql b/lkql_checker/share/lkql/implicit_small_for_fixed_point_types.lkql
@@ -22,3 +22,4 @@ fun implicit_small_for_fixed_point_types(node) =
     |"    end Foo;
     node is TypeDecl(any children: OrdinaryFixedPointDef,
                      p_has_aspect("Small"): false)
+    and node is not FormalTypeDecl
diff --git a/testsuite/tests/checks/small_for_fp/small.adb b/testsuite/tests/checks/small_for_fp/small.adb
@@ -0,0 +1,13 @@
+procedure Small is
+   type T1 is delta 0.01 range -1.0 .. 1.0;  -- FLAG
+   type T2 is delta 0.01 range -1.0 .. 1.0;  -- NOFLAG
+
+   generic
+     type T3 is delta <>;                   -- NOFLAG
+   package G is
+   end G;
+
+   for T2'Small use 0.01;
+begin
+   null;
+end Small;
diff --git a/testsuite/tests/checks/small_for_fp/test.out b/testsuite/tests/checks/small_for_fp/test.out
@@ -0,0 +1,4 @@
+small.adb:2:9: rule violation: fixed point type declaration with no 'Small clause
+2 |    type T1 is delta 0.01 range -1.0 .. 1.0;  -- FLAG
+  |         ^^
+
diff --git a/testsuite/tests/checks/small_for_fp/test.yaml b/testsuite/tests/checks/small_for_fp/test.yaml
@@ -0,0 +1,3 @@
+driver: 'checker'
+rule_name: implicit_small_for_fixed_point_types
+input_sources: ['small.adb']

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +small.adb:2:9: rule violation: fixed point type declaration with no 'Small clause
 +2 |    type T1 is delta 0.01 range -1.0 .. 1.0;  -- FLAG
 +  |         ^^
++
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+driver: 'checker'`
	`2`	`+rule_name: implicit_small_for_fixed_point_types`
	`3`	`+input_sources: ['small.adb']`