Remove useless function definition for 'Gnatcheck.Ids'

Author: HugoGGuerrier

lkql_checker/src/gnatcheck-ids.adb

@@ -34,40 +34,45 @@ package Gnatcheck.Ids is
      (Index_Type => Natural, Element_Type => Rule_Id);
    --  A simple vector to store rule identifiers
 
+   ------------------
+   -- Constant ids --
+   ------------------
+
+   No_Rule_Id : constant Rule_Id := Find (All_Rule_Ids, To_Text (""));
+   --  The empty identifier, used to express "no rule"
+
+   Restrictions_Id : constant Rule_Id :=
+     Find (All_Rule_Ids, To_Text ("restrictions"));
+   Style_Checks_Id : constant Rule_Id :=
+     Find (All_Rule_Ids, To_Text ("style_checks"));
+   Warnings_Id : constant Rule_Id :=
+     Find (All_Rule_Ids, To_Text ("warnings"));
+   --  Fake identifiers, used to represent the compiler checks
+
    ---------------------------
    -- Operation on rule ids --
    ---------------------------
 
-   function Find_Rule_Id (Rule_Name : String) return Rule_Id;
+   function Find_Rule_Id (Rule_Name : String) return Rule_Id is
+     (Find (All_Rule_Ids, To_Lower (To_Text (Rule_Name)), True));
    --  This function maps the `Find` function of `Langkit_Support.Symbols`
    --  to the `Rule_Id` type, allowing user to get or create a rule identifier
    --  from a simple string. Note that the input string is normalized before
    --  the getting or creation of the rule identifier.
 
-   function Get_Id_Text (Id : Rule_Id) return String;
+   function Get_Id_Text (Id : Rule_Id) return String is
+     (Image (To_Symbol (All_Rule_Ids, Id)));
    --  Get the text associated with the given `Rule_Id`, this text represents
    --  the normalized name of the rule identified by `Id`.
 
-   function Is_Compiler_Rule (Id : Rule_Id) return Boolean;
+   function Is_Compiler_Rule (Id : Rule_Id) return Boolean is
+     (Id = Restrictions_Id
+        or else Id = Warnings_Id
+        or else Id = Style_Checks_Id);
    --  Get whether the given rule identifier represents a compiler-based check
 
    function Hash (Id : Rule_Id) return Ada.Containers.Hash_Type is
      (Hash (To_Symbol (All_Rule_Ids, Thin_Symbol (Id))));
    --  Shortcut fonction to hash a rule identifier
 
-   ------------------
-   -- Constant ids --
-   ------------------
-
-   No_Rule_Id : constant Rule_Id := Find (All_Rule_Ids, To_Text (""));
-   --  The empty identifier, used to express "no rule"
-
-   Restrictions_Id : constant Rule_Id :=
-     Find (All_Rule_Ids, To_Text ("restrictions"));
-   Style_Checks_Id : constant Rule_Id :=
-     Find (All_Rule_Ids, To_Text ("style_checks"));
-   Warnings_Id : constant Rule_Id :=
-     Find (All_Rule_Ids, To_Text ("warnings"));
-   --  Fake identifiers, used to represent the compiler checks
-
 end Gnatcheck.Ids;