Ensure expression type is not null in KP-S814-034

Author: HugoGGuerrier

lkql_checker/share/lkql/kp/KP-S814-034.lkql

@@ -4,7 +4,7 @@ import stdlib
 fun kp_s814_034(node) =
     |" Flag array aggregates with an others choice if the array component type is a
     |" record type that has a string subcomponent.
-    node is Aggregate(p_is_subaggregate(): false, p_expression_type(): t)
+    node is Aggregate(p_is_subaggregate(): false, p_expression_type(): t@BaseTypeDecl)
     when
         # Check that the aggregate is not a nested array aggregate
         not node.p_is_subaggregate() and

testsuite/tests/checks/KP-S814-034/p.adb

@@ -1,10 +1,14 @@
 procedure P is
+   --  Ensure aggregates with no type don't trigger any error
+   type Example_Enum is (A, B, C);
+   for Example_Enum use (A => 0, B => 1, C => 2);                 --  NOFLAG
+
    Max_Error_Length : constant := 8;
    subtype Str is String (1 .. Max_Error_Length);
 
    S_Init : constant Str := "INIT    ";
 
-   type Rec is record
+   type Rec is tagged record
       Text : Str;
    end record;
 

testsuite/tests/checks/KP-S814-034/test.out

@@ -1,16 +1,16 @@
-p.adb:22:18: rule violation: possible occurrence of KP S814-034
-22 |       A : Arr := (others => (others => S_Init));                   --  FLAG
+p.adb:26:18: rule violation: possible occurrence of KP S814-034
+26 |       A : Arr := (others => (others => S_Init));                   --  FLAG
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-p.adb:23:22: rule violation: possible occurrence of KP S814-034
-23 |       M_A : M_Arr := (others => (others => R_Init));               --  FLAG
+p.adb:27:22: rule violation: possible occurrence of KP S814-034
+27 |       M_A : M_Arr := (others => (others => R_Init));               --  FLAG
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-p.adb:24:22: rule violation: possible occurrence of KP S814-034
-24 |       D_A : D_Arr := (others => (Text => S_Init, I => 2));         --  FLAG
+p.adb:28:22: rule violation: possible occurrence of KP S814-034
+28 |       D_A : D_Arr := (others => (Text => S_Init, I => 2));         --  FLAG
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-p.adb:28:6: rule violation: possible occurrence of KP S814-034
-28 |      (3 => (Text => "INVALID "), others => (Text => "OTHERS  "));  --  FLAG
+p.adb:32:6: rule violation: possible occurrence of KP S814-034
+32 |      (3 => (Text => "INVALID "), others => (Text => "OTHERS  "));  --  FLAG
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^